Check that CheckRegularTransaction rejects coinbases and vice-versa
ClosedPublic
Actions

Authored by deadalnix on Oct 2 2018, 17:24.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGING627cebb96e5f: Check that CheckRegularTransaction rejects coinbases and vice-versa
rABC627cebb96e5f: Check that CheckRegularTransaction rejects coinbases and vice-versa

Summary

This is somewhat of a hole in the test plan.

Test Plan

make check

Remove the coinbase check from CheckRegularTransaction and make sure that everything fails.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

testnoncoinbase

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3487
Build 5050: Bitcoin ABC Buildbot (legacy)
Build 5049: arc lint + arc unit

Event Timeline

deadalnix created this revision.Oct 2 2018, 17:24

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 2 2018, 17:24

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3487: Diff 5233.Oct 2 2018, 17:44

jasonbcox accepted this revision.Oct 3 2018, 03:08

This revision is now accepted and ready to land.Oct 3 2018, 03:08

Closed by commit rABC627cebb96e5f: Check that CheckRegularTransaction rejects coinbases and vice-versa (authored by deadalnix). · Explain WhyOct 3 2018, 11:28

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

transaction_tests.cpp

8 lines

Diff 5233

View Options

src/test/transaction_tests.cpp

Check that CheckRegularTransaction rejects coinbases and vice-versaClosedPublicActions