Differential D17589

[avalanche] Clear updates on each call to registerVotes
ClosedPublic
Actions

Authored by roqqit on Fri, Jan 24, 19:53.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC221da91fe481: [avalanche] Clear updates on each call to registerVotes

Summary

Since the API does not explicitly call for appending to updates, it is unintuitive for updates to not clear on each registerVotes call. This can lead to difficult to debug unit test failures where registerVotes appears to emit updates that were actually from past calls but never cleared.

Test Plan

ninja check-avalanche-processor_tests

Diff Detail

Repository

rABC Bitcoin ABC

Branch

ava-register-clear-updates

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32205
Build 63900: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-clang · build-debug · build-clang-tidy
Build 63899: arc lint + arc unit

Event Timeline

roqqit created this revision.Fri, Jan 24, 19:53

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Jan 24, 19:53

roqqit requested review of this revision.Fri, Jan 24, 19:53

roqqit added a child revision: D17590: [avalanche] Check that avalanche invalidated items no longer poll in the dont_poll_invalid_item test case.Fri, Jan 24, 20:07

Harbormaster completed remote builds in B32205: Diff 52369.Fri, Jan 24, 20:08

Fabien requested changes to this revision.Sat, Jan 25, 15:06

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/processor.cpp
601	not here, do it unconditionally at the beginning of the function

This revision now requires changes to proceed.Sat, Jan 25, 15:06

feedback

Harbormaster completed remote builds in B32234: Diff 52413.Mon, Jan 27, 20:23

Fabien accepted this revision.Mon, Jan 27, 21:26

This revision is now accepted and ready to land.Mon, Jan 27, 21:26

Closed by commit rABC221da91fe481: [avalanche] Clear updates on each call to registerVotes (authored by roqqit). · Explain WhyMon, Jan 27, 21:50

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC221da91fe481: [avalanche] Clear updates on each call to registerVotes.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

1 line

test/

processor_tests.cpp

7 lines

Diff 52369

src/avalanche/processor.cpp

Loading...

src/avalanche/test/processor_tests.cpp

Loading...