We want to make sure all rendered decimalized token quantities are in locale format, as it is otherwise very difficult to read the value
Have noticed these in normal app use
Details
Details
- Reviewers
Fabien - Group Reviewers
Restricted Project - Commits
- rABC81de6074a0f9: [Cashtab] Make listing amounts more readable in agora listing notifications
npm test
List an amount of some token greater than 1000
Confirm there is a locale thousands separator, i.e. "1,000" in the notification amount
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- locale-offer-notifications
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 32210 Build 63910: Build Diff cashtab-tests Build 63909: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs:
====== CashTab Unit Tests: <Agora /> We need to load all to see a non-whitelisted offer ======
TestingLibraryElementError: Unable to find an element with the text: No whitelisted tokens are currently listed for sale. Try loading all offers.. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.
Ignored nodes: comments, script, style
<body>
<div>
<div
class="sc-AnqlK jzmxJP"
>
<section
aria-atomic="false"
aria-label="Notifications Alt+T"
aria-live="polite"
aria-relevant="additions text"
class="Toastify"
/>
<div
class="sc-keFjpB kpRoMq"
>
<div
class="sc-jWojfa dWofVP"
>
<div
class="sc-dTLGrV hVKRQa"
>
<img
alt="cashtab"
class="sc-ivVeuv evHkvQ"
src="test-file-stub"
/>
</div>
<div
class="sc-hdPSEv NMixZ"
>
<div
class="sc-bqjOQT bJwGKq"
>
<select
class="sc-jkCMRl fVHViG"
data-testid="wallet-select"
id="wallets"
name="wallets"
>
<option
class="sc-crNyjn fdrrlO"
value="Agora Partial Alpha"
>
Agora Partial Alpha
</option>
<option
class="sc-crNyjn fdrrlO"
value="Agora Partial Beta"
>
Agora Partial Beta
</option>
</select>
<div
class="sc-lcpuFF iSIgFF"
>
<button
aria-label="Copy ecash:qqpmsv8yh8wwx3lnf92rrc0e6yq97j6zqs8av8vx8h"
class="sc-cJSrbW kZNvLw"
>
<svg
title="copy-paste"
/>
</button>
<div
class="sc-eerKOB cvXwwv"
>
<div
class="sc-emmjRN bSWkUh"
>
<input
checked=""
class="sc-gFaPwZ iPJMNd"
id="show-hide-balance"
name="show-hide-balance"
title="show-hide-balance"
type="checkbox"
/>
<label
class="sc-cpmLhU iUeRKn"
for="show-hide-balance"
>
<span
class="sc-dymIpo hGwQkt"
data-off=""
data-on=""
/>
<span
class="sc-bnXvFD cpOMDW"
/>
</label>
</div>
</div>
</div>
</div>
<div
class="sc-cmIlrE dkSzlg"
title="Wallet Info"
>
<div
class="sc-cpHetk jEKVml"
>
<div
class="sc-nrwXf bsChRe"
title="Balance XEC"
>
4,200.00
XEC
</div>
</div>
<div
class="sc-eitiEO lmPAIm"
title="Balance in Local Currency"
>
$
0.13
USD
</div>
<p
class="sc-bhlBdH umymk"
title="Price in Local Currency"
>
1
XEC
=
0.00003000
USD
</p>
</div>
</div>
<div
class="sc-chAAoq bzVCQv"
>
<div
class="sc-yZwTr birQAH"
>
<h2>
Token Offers
</h2>
<div>
Sort by:
<div
class="sc-hwcHae jnZGJM"
title="Sort by TokenId"
>
TokenID
</div>
<div
class="sc-hwcHae dfnqEL"
disabled=""
title="Sort by Offer Count"
>
Offers
<div>
<div
class="sc-jzJRlG eQTBdJ"
title="Loading OrderBook info..."
>
<div />
<div />
<div />
<div />
</div>
</div>
</div>
<span
class="sc-fjhmcy ceHQEJ"
title="Toggle Active Offers"
>
My Listings
</span>
</div>
</div>
<div
class="sc-gacfCG gpjPEu"
title="Active Offers"
>
<div
class="sc-cqPOvA jDuRbt"
>
<div
class="sc-eKZiaR cOnhGl"
>
<div
class="sc-jzJRlG eQTBdJ"
title="Loading"
>
<div />
<div />
<div />
<div />
</div>
</div>
<div
class="sc-eKZiaR cOnhGl"
>
<div
class="sc-jzJRlG eQTBdJ"
title="Loading"
>
<div />
<div />
<div />
<div />
</div>
</div>
</div>
</div>
<button
class="sc-caSCKo sc-kjoXOD DHATx"
style="margin-top: 12px;"
>
Load all offers
</button>
</div>
</div>
<div
class="sc-kVrTmx exLrES"
>
<div
class="sc-fHSTwm jBcETl"
>
<img
alt="cashtab"
class="sc-ivVeuv evHkvQ"
src="test-file-stub"
/>
</div>
<button
class="sc-jvEmr hqZIZM"
>
<span>
Transactions
</span>
<svg />
</button>
<button
aria-label="Send Screen"
class="sc-jvEmr hqZIZM"
>
<span>
Send
</span>
<svg
title="tx-sent"
/>
</button>
<button
aria-label="Tokens"
class="sc-jvEmr hqZIZM"
>
<span>
Tokens
</span>
<svg
title="Tokens"
/>
</button>
<button
aria-label="Receive"
class="sc-jvEmr hqZIZM"
>
<span>
Receive
</span>
<svg
title="tx-received"
/>
</button>
<div
class="sc-ekkqgF dcQEnG"
title="Show Other Screens"
>
<span
class="sc-iBmynh dPVmzy"
/>
<div
class="sc-fKGOjr buAdOz"
title="Other Screens"
>
<button
class="sc-hycgNl bNyILw"
>
<p>
Wallet Backup
</p>
<svg
title="wallet"
/>
</button>
<button
class="sc-hycgNl bNyILw"
>
<p>
Wallets
</p>
<svg
title="wallets"
/>
</button>
<button
class="sc-hycgNl bNyILw"
>
<p>
Listed NFTs
</p>
<svg
title="NFT"
/>
</button>
<button
class="sc-hycgNl bNyILw"
>
<p>
Agora
</p>
<svg
title="Meme Agora"
/>
</button>
<button
class="sc-hycgNl bNyILw"
>
<p>
Contacts
</p>
<svg
title="Contact List"
/>
</button>
<button
class="sc-hycgNl bNyILw"
>
<p>
Airdrop
</p>
<svg
title="tx-airdrop"
/>
</button>
<button
class="sc-hycgNl bNyILw"
>
<p>
Rewards
</p>
<svg
title="Cashtab Rewards"
/>
</button>
<button
class="sc-hycgNl bNyILw"
>
<p>
Sign & Verify
</p>
<svg
class="sc-htpNat bPFBeM"
/>
</button>
<button
class="sc-hycgNl bNyILw"
>
<p>
Settings
</p>
<svg
title="settings"
/>
</button>
</div>
</div>
</div>
</div>
</div>
</div>
</body>
at Object.getElementError (/work/cashtab/node_modules/@testing-library/dom/dist/config.js:37:19)
at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:76:38
at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:52:17
at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:95:19
at Object.getByText (/work/cashtab/src/components/Agora/__tests__/index.test.js:332:20)
at runNextTicks (node:internal/process/task_queues:60:5)
at listOnTimeout (node:internal/timers:545:9)
at processTimers (node:internal/timers:519:7)Each failure log is accessible here:
CashTab Unit Tests: <Agora /> We need to load all to see a non-whitelisted offer
| cashtab/src/components/Agora/__tests__/index.test.js | ||
|---|---|---|
| 313 | not strictly related to this diff, but part of expected flakiness patching as a result of patching an issue with app-wide loading spinner logic imo it is useful to keep these changes in the diffs that uncover them | |