[Cashtab] Support buying agora offers above spot, within reason
ClosedPublic
Actions

Authored by bytesofman on Thu, Jan 30, 00:16.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC76ae72c209be: [Cashtab] Support buying agora offers above spot, within reason

Summary

Agora has some unique properties compared to other exchanges. One of these: users may set a "min buy" parameter when they create an offer.

It makes sense that an offer with a lower "min buy" may reasonably have a higher price than offer with a higher "min buy" (economies of scale).

Support buying above spot, up to 25% over spot.

We could update this parameter in the future depending on how it is being used. The main use case now seems to be users would like to buy XECX for prices < 1% above spot that have lower min quantities.

Test Plan

npm test

Deployed to test site, check version for 3.12.15

Check XECX page
https://cashtab-local-dev.netlify.app/#/token/c67bf5c2b6d91cfb46a5c1772582eff80d88686887be10aa63b0945479cf4ed4

We can buy ("OK" button enabled) an offer above spot, but we do see a warning that it is above spot

We cannot buy an offer more than 25% above spot (OK button disabled), and we see warning + alert

Diff Detail

Repository

rABC Bitcoin ABC

Branch

agora-support-buys-above-spot-within-reason

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32252
Build 63994: Build Diff	cashtab-tests
Build 63993: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Jan 30, 00:16

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Jan 30, 00:16

Harbormaster completed remote builds in B32252: Diff 52438.Thu, Jan 30, 00:22

version bump, preserve above spot warning for prices above spot, even those that are not disabled

bytesofman edited the test plan for this revision. (Show Details)Thu, Jan 30, 00:29

Harbormaster completed remote builds in B32253: Diff 52439.Thu, Jan 30, 00:32

bytesofman published this revision for review.Thu, Jan 30, 00:34

bytesofman added inline comments.

cashtab/src/components/Agora/OrderBook/index.tsx
990 ↗	(On Diff #52439)	the check logic looks pretty complicated (was before this diff too) arguably we should move it to a function. But, so far, it isn't repeated. And we are just comparing two numbers, with some extra checks that are mostly type related.