Page MenuHomePhabricator

[Cashtab] Patch button css
ClosedPublic

Authored by bytesofman on Sat, Feb 1, 23:13.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABCb6b377f844aa: [Cashtab] Patch button css
Summary

we can't have "1px solid none" ... it "works" since we get "none" but it is bad syntax

Test Plan

npm test, no change in behavior expected, just cleaning up

Diff Detail

Repository
rABC Bitcoin ABC
Branch
button-style-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32285
Build 64060: Build Diffcashtab-tests
Build 64059: arc lint + arc unit

Event Timeline

Tail of the build log:

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-lib@1.5.0 build
> tsc && tsc -p ./tsconfig.build.json && cp -r ./src/ffi ./dist

/work/modules/ecash-agora /work/abc-ci-builds/cashtab-tests

added 364 packages, and audited 367 packages in 2s

60 packages are looking for funding
  run `npm fund` for details

2 vulnerabilities (1 moderate, 1 high)

To address all issues, run:
  npm audit fix

Run `npm audit` for details.

> ecash-agora@0.3.1 build
> tsc && tsc -p ./tsconfig.build.json

/work/cashtab /work/abc-ci-builds/cashtab-tests
npm warn deprecated @humanwhocodes/config-array@0.11.14: Use @eslint/config-array instead
npm warn deprecated @humanwhocodes/object-schema@2.0.3: Use @eslint/object-schema instead
npm warn deprecated eslint@8.56.0: This version is no longer supported. Please see https://eslint.org/version-support for other options.

added 1494 packages, and audited 3315 packages in 24s

320 packages are looking for funding
  run `npm fund` for details

8 vulnerabilities (4 moderate, 4 high)

To address issues that do not require attention, run:
  npm audit fix

To address all issues (including breaking changes), run:
  npm audit fix --force

Run `npm audit` for details.

> cashtab@3.12.15 build
> node scripts/build.js

Creating an optimized production build...
Failed to compile.

Attempted import error: 'SecondaryButton' is not exported from 'components/Common/Buttons' (imported as 'SecondaryButton').


Build cashtab-tests failed with exit code 1
bytesofman published this revision for review.Sat, Feb 1, 23:32

note the test failure is from when I first put the diff up having accidentally deleted the file

This revision is now accepted and ready to land.Sun, Feb 2, 03:36
This revision was automatically updated to reflect the committed changes.