[chronik] Add blockchain_info to bitcoinsuite-chronik-client
Needs RevisionPublic
Actions

Authored by hazzarust on Tue, Feb 4, 23:05.

Details

Reviewers

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Summary

Depends on D17595 - this diff uses features from D17595 such as the test_runner and handler.

Use the bitcoinsuite-chronik-client to return the tip height and tip hash length, thus we can compare with the python bitcoin tests and assert if they are equal.

Test Plan

Please set BUILD_DIR env to export BUILD_DIR="/path/to/build_dir
UNIX: ./contrib/teamcity/build-configurations.py build-bitcoinsuite-chronik-client
cd modules/bitcoinsuite-chronik-client && cargo test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

blockchain_info

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32312
Build 64113: Build Diff	build-bitcoinsuite-chronik-client
Build 64112: arc lint + arc unit

Event Timeline

hazzarust requested review of this revision.Tue, Feb 4, 23:05

hazzarust created this revision.

Harbormaster completed remote builds in B32312: Diff 52524.Tue, Feb 4, 23:11

hazzarust edited the summary of this revision. (Show Details)Tue, Feb 4, 23:11

hazzarust edited the test plan for this revision. (Show Details)

PiRK edited the summary of this revision. (Show Details)Thu, Feb 6, 09:39

PiRK added a parent revision: Restricted Differential Revision.

PiRK added a subscriber: PiRK.Fri, Feb 7, 11:13

PiRK added inline comments.

modules/bitcoinsuite-chronik-client/tests/blockchain_info.rs
16	you probably want to use a cross platform function here (maybe `std::env::temp_dir()`?), just so we don't introduce issues in case we want to run tests on windows some day

See the feedback from D17595: remove the debug statements, and rebase. The suggestion from Pierre is also a good one that you should take into account. Otherwise the state machine looks good to me.

This revision now requires changes to proceed.Mon, Feb 10, 11:09

Revision Contents
Changeset List

Path

Size

modules/

bitcoinsuite-chronik-client/

tests/

blockchain_info.rs

166 lines

Diff 52524

View Options

modules/bitcoinsuite-chronik-client/tests/blockchain_info.rs

[chronik] Add blockchain_info to bitcoinsuite-chronik-clientNeeds RevisionPublicActions