Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC3d80d5ddb170: [Cashtab] Support one-click redemptions for XECX

Summary

Users commonly have errors in setting the price to exactly 1, which is what XECX is redeemed for. Simplify this workflow.

Test Plan

npm test

check it out at https://cashtab-local-dev.netlify.app/

Diff Detail

Repository

rABC Bitcoin ABC

Branch

one-click-xecx-redemptions

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32330
Build 64149: Build Diff	cashtab-tests
Build 64148: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Feb 6, 15:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 6, 15:07

Harbormaster completed remote builds in B32330: Diff 52549.Thu, Feb 6, 15:12

lose the tooltip and improve switch label instead

patch toggle issue

Harbormaster completed remote builds in B32336: Diff 52555.Thu, Feb 6, 15:36

Harbormaster completed remote builds in B32337: Diff 52556.

bytesofman edited the test plan for this revision. (Show Details)Thu, Feb 6, 17:26

improve logic for setting the min qty on redemptions

Harbormaster completed remote builds in B32339: Diff 52558.Thu, Feb 6, 17:49

back out unrelated changes, debug log

Harbormaster completed remote builds in B32340: Diff 52560.Thu, Feb 6, 18:03

bytesofman published this revision for review.Thu, Feb 6, 18:09

Unable to redeem 7ish XECX for XEC, this is above dust so should be possible?

Redemption worked fine for 10k XECX.

This revision now requires changes to proceed.Fri, Feb 7, 10:01

show dust error

In D17641#401568, @emack wrote:

Unable to redeem 7ish XECX for XEC, this is above dust so should be possible?

Redemption worked fine for 10k XECX.

most likely this is an earlier version of this diff at the deploy site, there was an issue with min qty not being set, which would create a hidden error

I updated the screen so we get the dust validation msg, otherwise the button could be mystery-disabled
I version bumped and deployed, so make sure the test site is on version 3.13.5