Paths

Table of Contentst

Differential D17645

wallet: make chain optional for CWallet::Create
ClosedPublic
Actions

Authored by PiRK on Feb 6 2025, 15:10.

Details

Reviewers

roqqit

Group Reviewers

Restricted Project

Commits

rABC95c17f9917b3: wallet: make chain optional for CWallet::Create

Summary

This concludes backport of core#20733
https://github.com/bitcoin/bitcoin/pull/20773/commits/489ebb7b34c403a3ce78ff6fb271f8e6ecb47304
Depends on D17644

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32334
Build 64157: Build Diff	lint-circular-dependencies · build-without-wallet · build-diff · build-debug · build-clang-tidy · build-clang
Build 64156: arc lint + arc unit

Event Timeline

PiRK created this revision.Feb 6 2025, 15:10

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 6 2025, 15:10

PiRK requested review of this revision.Feb 6 2025, 15:10

teamcity edited the summary of this revision. (Show Details)Feb 6 2025, 15:10

PiRK added a child revision: D17646: wallet: avoid rescans if under the snapshot.Feb 6 2025, 15:11

Harbormaster completed remote builds in B32334: Diff 52553.Feb 6 2025, 15:34

roqqit accepted this revision.Feb 7 2025, 19:09

This revision is now accepted and ready to land.Feb 7 2025, 19:09

Closed by commit rABC95c17f9917b3: wallet: make chain optional for CWallet::Create (authored by Ivan Metlushko <metlushko@gmail.com>, committed by PiRK). · Explain WhyFeb 8 2025, 10:32

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC95c17f9917b3: wallet: make chain optional for CWallet::Create.

Revision Contents
Changeset List

Path

Size

src/

wallet/

load.cpp

2 lines

test/

wallet_tests.cpp

20 lines

wallet.h

2 lines

wallet.cpp

26 lines

Diff 52553

View Options

src/wallet/load.cpp

View Options

src/wallet/test/wallet_tests.cpp

View Options

src/wallet/wallet.h

View Options

wallet: make chain optional for CWallet::CreateClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 52553

src/wallet/load.cpp

src/wallet/test/wallet_tests.cpp

src/wallet/wallet.h

src/wallet/wallet.cpp

wallet: make chain optional for CWallet::Create
ClosedPublic
Actions

Revision Contents
Changeset List