Page MenuHomePhabricator
Differential D17641

[Cashtab] Support one-click redemptions for XECX
Needs ReviewPublic
Actions

Authored by bytesofman on Thu, Feb 6, 15:07.

Details

Reviewers
None
Group Reviewers
Restricted Project
Summary

Users commonly have errors in setting the price to exactly 1, which is what XECX is redeemed for. Simplify this workflow.

Test Plan

npm test

check it out at https://cashtab-local-dev.netlify.app/

Diff Detail

Repository
rABC Bitcoin ABC
Branch
one-click-xecx-redemptions
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32339
Build 64167: Build Diffcashtab-tests
Build 64166: arc lint + arc unit

Event Timeline

bytesofman created this revision.Thu, Feb 6, 15:07
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 6, 15:07
Harbormaster completed remote builds in B32330: Diff 52549.Thu, Feb 6, 15:12
bytesofman updated this revision to Diff 52555.Thu, Feb 6, 15:14

lose the tooltip and improve switch label instead

bytesofman updated this revision to Diff 52556.Thu, Feb 6, 15:15

patch toggle issue

Harbormaster completed remote builds in B32336: Diff 52555.Thu, Feb 6, 15:36
Harbormaster completed remote builds in B32337: Diff 52556.
bytesofman edited the test plan for this revision. (Show Details)Thu, Feb 6, 17:26
bytesofman updated this revision to Diff 52558.Thu, Feb 6, 17:44
bytesofman edited the test plan for this revision. (Show Details)

improve logic for setting the min qty on redemptions

Harbormaster completed remote builds in B32339: Diff 52558.Thu, Feb 6, 17:49
bytesofman updated this revision to Diff 52560.Thu, Feb 6, 17:51

back out unrelated changes, debug log

Harbormaster completed remote builds in B32340: Diff 52560.Thu, Feb 6, 18:03
bytesofman published this revision for review.Thu, Feb 6, 18:09

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Common/
4 lines
Etokens/
Token/
152 lines
__tests__/
129 lines
fixtures/
50 lines

Diff 52558

View Options

cashtab/src/components/Common/Buttons.tsx

Loading...
View Options

cashtab/src/components/Etokens/Token/index.tsx

Loading...
View Options

cashtab/src/components/Etokens/__tests__/TokenActions.test.js

Loading...
View Options

cashtab/src/components/Etokens/fixtures/mocks.js

Loading...