Currently we display the price of the selected qty. But really we cancel the whole offer. So we should just display the spot price.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
npm test
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- show-price-of-all-when-canceling
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 32344 Build 64177: Build Diff cashtab-tests Build 64176: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs:
====== CashTab Unit Tests: <Agora /> We can see multiple offers, some we made, others we did not, and we can cancel an offer ====== TestingLibraryElementError: Unable to find an element with the text: Cancel your offer to sell 888 Bull (BULL) for 400,424.96 XEC ($12.01 USD)?. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible. Ignored nodes: comments, script, style <body> <div> <div class="sc-keFjpB fuvsSf" > <section aria-atomic="false" aria-label="Notifications Alt+T" aria-live="polite" aria-relevant="additions text" class="Toastify" /> <div class="sc-jWojfa gOMhPW" > <div class="sc-kVrTmx dSIcDd" > <div class="sc-ivVeuv hQBWoJ" > <img alt="cashtab" class="sc-cCbXAZ jOUSPN" src="test-file-stub" /> </div> <div class="sc-cmIlrE ckvYmi" > <div class="sc-jkCMRl gxKbjs" > <select class="sc-crNyjn cynGtO" data-testid="wallet-select" id="wallets" name="wallets" > <option class="sc-cpHetk jodErs" value="Agora Partial Alpha" > Agora Partial Alpha </option> <option class="sc-cpHetk jodErs" value="Agora Partial Beta" > Agora Partial Beta </option> </select> <div class="sc-bqjOQT kauMuv" > <button aria-label="Copy ecash:qqpmsv8yh8wwx3lnf92rrc0e6yq97j6zqs8av8vx8h" class="sc-cJSrbW kZNvLw" > <svg title="copy-paste" /> </button> <div class="sc-eerKOB cvXwwv" > <div class="sc-emmjRN bSWkUh" > <input checked="" class="sc-gFaPwZ iPJMNd" id="show-hide-balance" name="show-hide-balance" title="show-hide-balance" type="checkbox" /> <label class="sc-cpmLhU iUeRKn" for="show-hide-balance" > <span class="sc-dymIpo hGwQkt" data-off="" data-on="" /> <span class="sc-bnXvFD cpOMDW" /> </label> </div> </div> </div> </div> <div class="sc-gleUXh fSfkBQ" title="Wallet Info" > <div class="sc-nrwXf erXBln" > <div class="sc-eitiEO isWDMZ" title="Balance XEC" > 4,200.00 XEC </div> </div> <div class="sc-bhlBdH kdHsOB" title="Balance in Local Currency" > $ 0.13 USD </div> <p class="sc-AnqlK fLVAuQ" title="Price in Local Currency" > 1 XEC = 0.00003000 USD </p> </div> </div> <div class="sc-dTLGrV eQoClh" > <div class="sc-fjhmcy ezvQuX" > <h2> Token Offers </h2> <div> Sort by: <div class="sc-lnmtFM jhgFyV" title="Sort by TokenId" > TokenID </div> <div class="sc-lnmtFM eOVXQv" title="Sort by Offer Count" > Offers </div> <span class="sc-hwcHae deuxbw" title="Toggle Active Offers" > My Listings </span> </div> </div> <div class="sc-dEfkYy goEHKM" title="Active Offers" > <div class="sc-gNJABI kBcfbd" > <div class="sc-cIShpX jOmaan" height="2... at Object.getElementError (/work/cashtab/node_modules/@testing-library/dom/dist/config.js:37:19) at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:76:38 at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:52:17 at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:95:19 at Object.getByText (/work/cashtab/src/components/Agora/__tests__/index.test.js:851:20) at runNextTicks (node:internal/process/task_queues:60:5) at processTimers (node:internal/timers:516:9)
Each failure log is accessible here:
CashTab Unit Tests: <Agora /> We can see multiple offers, some we made, others we did not, and we can cancel an offer