Page MenuHomePhabricator

[ecash-agora] Do not validate for unspendable offers when estimating the fee
ClosedPublic

Authored by bytesofman on Fri, Feb 7, 14:27.

Details

Summary

Open question whether or not we should support allowing the creation of unacceptable offers in this lib at all. Unrelated to this diff tho. For now, this is something that can be manually specified in the lib, because it is something the protocol technically allows.

However, when we just want to estimate a fee, we should not be validating for this condition. Just estimate the fee.

Test Plan

CI tests

Diff Detail

Repository
rABC Bitcoin ABC
Branch
agora-param-patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32347
Build 64183: Build Diffecash-agora-tests · cashtab-tests · ecash-agora-integration-tests
Build 64182: arc lint + arc unit