Differential D17607

[avalanche] Poll for stake contenders
ClosedPublic
Actions

Authored by roqqit on Wed, Jan 29, 23:51.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC0ab1dbf3adcc: [avalanche] Poll for stake contenders

Summary

Poll for stake contenders after they have been promoted to a new chain tip.

Responses to polls will be handled in a follow up diff.

Depends on D17615

Test Plan

ninja check-functional

Diff Detail

Repository

rABC Bitcoin ABC

Branch

sc-poll

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32426
Build 64341: Build Diff	lint-circular-dependencies · build-clang · build-clang-tidy · build-diff · build-without-wallet · build-debug
Build 64340: arc lint + arc unit

Event Timeline

roqqit created this revision.Wed, Jan 29, 23:51

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Jan 29, 23:51

Harbormaster completed remote builds in B32251: Diff 52437.Thu, Jan 30, 00:00

split diff apart

roqqit published this revision for review.Thu, Jan 30, 17:03

roqqit edited the summary of this revision. (Show Details)

roqqit edited the test plan for this revision. (Show Details)

roqqit added a parent revision: D17615: [avalanche] Add stake contender to AnyVoteItem.

Harbormaster completed remote builds in B32264: Diff 52453.Thu, Jan 30, 17:13

Fabien requested changes to this revision.Thu, Jan 30, 20:45

Fabien added a subscriber: Fabien.

Fabien added inline comments.

src/avalanche/processor.cpp
1069 ↗	(On Diff #52453)	This function is no longer doing this but much more. Either change the name or split the function (probably better as it makes unit testing possible). It also causes the addToReconcile to happen twice per block because this function is called upon updatedBlockTip as well as when staking reward winners are computed.

This revision now requires changes to proceed.Thu, Jan 30, 20:45

roqqit mentioned this in D17660: [avalanche] Improve API for setContenderStatusForLocalWinners.Wed, Feb 12, 19:03

roqqit mentioned this in rABC2c29ef6261c7: [avalanche] Improve API for setContenderStatusForLocalWinners.Fri, Feb 14, 17:52

Rebase on D17660 to address the feedback about splitting up setContenderStatusForLocalWinners(). It should be more clear now that addToReconcile() is only called once per block.

Harbormaster completed remote builds in B32426: Diff 52684.Wed, Feb 19, 22:18

Fabien added inline comments.Thu, Feb 20, 08:37

src/avalanche/processor.cpp
1080	Can you remind me why you need it in 2 places ?

Fabien accepted this revision.Fri, Feb 21, 08:41

Fabien added inline comments.

src/avalanche/processor.cpp
1080	Answer to self: the staking rewards computation also happens at the time the quorum is established, so the contenders might not be promoted to the tip yet.

This revision is now accepted and ready to land.Fri, Feb 21, 08:41

Closed by commit rABC0ab1dbf3adcc: [avalanche] Poll for stake contenders (authored by roqqit). · Explain WhyFri, Feb 21, 22:07

This revision was automatically updated to reflect the committed changes.

roqqit added a commit: rABC0ab1dbf3adcc: [avalanche] Poll for stake contenders.