Page MenuHomePhabricator
Differential D17712

[e.cash] Update copy on Build page
AcceptedPublic
Actions

Authored by Mengerian on Thu, Feb 27, 00:35.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Summary

Add some explanation of what makes eCash such a great platform to build on

Test Plan

Run it locally, read though the words

Diff Detail

Repository
rABC Bitcoin ABC
Branch
e.cash-build-update-copy
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32511
Build 64510: Build Diff
Build 64509: arc lint + arc unit

Event Timeline

Mengerian created this revision.Thu, Feb 27, 00:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Feb 27, 00:35
Harbormaster completed remote builds in B32508: Diff 52792.Thu, Feb 27, 00:35
Mengerian updated this revision to Diff 52793.Thu, Feb 27, 00:37

Fix linting errors

Harbormaster completed remote builds in B32509: Diff 52793.Thu, Feb 27, 00:37
Mengerian updated this revision to Diff 52794.Thu, Feb 27, 00:40

Typos

bytesofman added a comment.Thu, Feb 27, 00:40

@bot preview-e.cash

Harbormaster completed remote builds in B32510: Diff 52794.Thu, Feb 27, 00:40
teamcity awarded a token.Thu, Feb 27, 00:40

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41671 for the next 60 minutes.

Klakurka added a subscriber: Klakurka.Thu, Feb 27, 00:42
Klakurka added inline comments.
web/e.cash/pages/build.js
137 ↗(On Diff #52793)
bytesofman added inline comments.Thu, Feb 27, 00:47
web/e.cash/pages/build.js
131 ↗(On Diff #52794)
138 ↗(On Diff #52794)
Mengerian updated this revision to Diff 52795.Thu, Feb 27, 01:07
Mengerian marked 3 inline comments as done.

Fix typos per review comments

Harbormaster completed remote builds in B32511: Diff 52795.Thu, Feb 27, 01:07
Mengerian updated this revision to Diff 52796.Thu, Feb 27, 01:08

Remove "Our Philosophy" section

Harbormaster completed remote builds in B32512: Diff 52796.Thu, Feb 27, 01:08
Mengerian published this revision for review.Thu, Feb 27, 01:09
bytesofman added a comment.Thu, Feb 27, 01:10

@bot preview-e.cash

teamcity updated a token.Thu, Feb 27, 01:10

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41146 for the next 60 minutes.

bytesofman added a comment.Thu, Feb 27, 03:58

@bot preview-e.cash

teamcity updated a token.Thu, Feb 27, 03:58

Build Bitcoin ABC Diffs / Diff Testing (preview-e.cash) passed.
Preview is available at http://51.68.37.192:41502 for the next 60 minutes.

bytesofman accepted this revision.Thu, Feb 27, 04:07

some suggestions trying to tighten up the copy, go with whatever you think is best. I don't think anyone reads something longer than a full sentence on the internet anymore. But we really only need a handful of people who "get it" to see this stuff, so I don't think we need to worry about general consumption too much here.

web/e.cash/pages/build.js
128–133 ↗(On Diff #52796)
136–142 ↗(On Diff #52796)
This revision is now accepted and ready to land.Thu, Feb 27, 04:07

Revision Contents
Changeset List

PathSize
web/
e.cash/
pages/
24 lines

Diff 52795

View Options

web/e.cash/pages/build.js

Loading...