[ecash-herald] Do not use polling for the telegram bot
ClosedPublic
Actions

Authored by bytesofman on Fri, Feb 28, 15:48.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCf718de701eb1: [ecash-herald] Do not use polling for the telegram bot

Summary

The bot only sends msgs, it does not need to monitor any msgs for pending actions. "polling" means periodically hitting the telegram API to check for new msgs. We should not do this as we do not need this feature in herald (unused).

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-no-polling

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32546
Build 64580: Build Diff	ecash-herald-tests
Build 64579: arc lint + arc unit

Event Timeline

bytesofman created this revision.Fri, Feb 28, 15:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 28, 15:48

Harbormaster completed remote builds in B32546: Diff 52851.Fri, Feb 28, 15:52

bytesofman added a child revision: D17725: [ecash-herald] Send daily summaries to the main chat.Fri, Feb 28, 15:57

bytesofman published this revision for review.Fri, Feb 28, 15:59

PiRK accepted this revision.Fri, Feb 28, 20:10

This revision is now accepted and ready to land.Fri, Feb 28, 20:10

Closed by commit rABCf718de701eb1: [ecash-herald] Do not use polling for the telegram bot (authored by bytesofman). · Explain WhyFri, Feb 28, 21:42

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABCf718de701eb1: [ecash-herald] Do not use polling for the telegram bot.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

index.ts

2 lines

Diff 52851

View Options

apps/ecash-herald/index.ts

[ecash-herald] Do not use polling for the telegram botClosedPublicActions