Paths

Table of Contentst

Differential D17731

[ecash-herald] Show the date of the activity in the msg header
ClosedPublic
Actions

Authored by bytesofman on Fri, Feb 28, 22:19.

Details

Reviewers

emack

Group Reviewers

Restricted Project

Commits

rABC8fe9069a9b06: [ecash-herald] Show the date of the activity in the msg header

Summary

We are currently showing the "next" date since we build the msg at UTC midnight. But the activity is from the previous day.

Make sure we show the previous day's date.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

herald-patch-daily-date

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32555
Build 64598: Build Diff	ecash-herald-tests
Build 64597: arc lint + arc unit

Event Timeline

bytesofman created this revision.Fri, Feb 28, 22:19

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Feb 28, 22:19

Harbormaster completed remote builds in B32555: Diff 52866.Fri, Feb 28, 22:40

bytesofman published this revision for review.Fri, Feb 28, 22:43

emack accepted this revision.Sat, Mar 1, 07:17

This revision is now accepted and ready to land.Sat, Mar 1, 07:17

Closed by commit rABC8fe9069a9b06: [ecash-herald] Show the date of the activity in the msg header (authored by bytesofman). · Explain WhySat, Mar 1, 13:20

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC8fe9069a9b06: [ecash-herald] Show the date of the activity in the msg header.

Revision Contents
Changeset List

Path

Size

apps/

ecash-herald/

src/

parse.ts

16 lines

test/

parse.test.ts

6 lines

Diff 52866

View Options

apps/ecash-herald/src/parse.ts