Page MenuHomePhabricator

[avalanche] Fix a race in contenders voting test (again)
ClosedPublic

Authored by roqqit on Mon, Mar 3, 16:57.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC489c9cfea31a: [avalanche] Fix a race in contenders voting test (again)
Summary

D17729 attempted to fix this race but erroneously assumes that once one peer gets a poll, all of them will have it. The better solution is to answer polls until we find the contenders we're looking for and then do the checks on that same poll request.

Test Plan

Run the test a bunch of times:

for I in {0..20}; do ./test/functional/test_runner.py abc_p2p_avalanche_contender_voting || break ; done

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sc-fix-contender-flakiness
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32569
Build 64626: Build Diffbuild-clang · build-debug · build-diff · build-clang-tidy · build-without-wallet
Build 64625: arc lint + arc unit