Differential D17819

[electrum] include metadata for slip10 for the windows and osx releases
ClosedPublic
Actions

Authored by PiRK on Tue, Mar 18, 16:32.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCa370271feb5e: [electrum] include metadata for slip10 for the windows and osx releases

Summary

Similar to what was done in D17785, we need to make sure the slip10 library is packaged with its metadata.

Test Plan

Build the windows release and test a trezor device. The error fixed by this diff would prevent connecting to the device, so it is enough to just successfully restore or open a Trezor wallet.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

electrum_v5.4.1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32756
Build 65000: Build Diff	electrum-tests
Build 64999: arc lint + arc unit

Event Timeline

PiRK created this revision.Tue, Mar 18, 16:32

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Mar 18, 16:32

Harbormaster completed remote builds in B32756: Diff 53157.Tue, Mar 18, 16:35

PiRK edited the test plan for this revision. (Show Details)Wed, Mar 19, 07:16

PiRK published this revision for review.Wed, Mar 19, 07:45

PiRK edited the test plan for this revision. (Show Details)

Fabien accepted this revision.Wed, Mar 19, 08:15

This revision is now accepted and ready to land.Wed, Mar 19, 08:15

Closed by commit rABCa370271feb5e: [electrum] include metadata for slip10 for the windows and osx releases (authored by PiRK). · Explain WhyWed, Mar 19, 08:17

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCa370271feb5e: [electrum] include metadata for slip10 for the windows and osx releases.

Revision Contents
Changeset List

Path

Size

electrum/

contrib/

build-wine/

deterministic.spec

4 lines

osx/

osx.spec

3 lines

Diff 53157

View Options

electrum/contrib/build-wine/deterministic.spec