[electrum] Catch a potential LibUSB error during session close when jumping to bootloader
ClosedPublic
Actions

Authored by Fabien on Fri, Mar 21, 11:05.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABC269465eb445f: [electrum] Catch a potential LibUSB error during session close when jumping to…

Summary

The issue exists some machines/OS/devices (still unclear) that libusb raises an error when the session is closed during a reboot to bootloader. Since this does not affect the upgrade process we can safely catch and ignore this error as a workaround.

Test Plan

Tested on a failing machine/os/device combination.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

electrum_libusb_session_close

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32796
Build 65080: Build Diff	electrum-tests
Build 65079: arc lint + arc unit

Event Timeline

Fabien created this revision.Fri, Mar 21, 11:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Mar 21, 11:05

Fabien requested review of this revision.Fri, Mar 21, 11:05

Harbormaster completed remote builds in B32796: Diff 53220.Fri, Mar 21, 11:07

PiRK accepted this revision.Fri, Mar 21, 11:21

PiRK added a subscriber: PiRK.

PiRK added inline comments.

electrum/electrumabc_plugins/trezor/clientbase.py
362–371	for simple `try: ... except SomeError: pass` blocks I usually prefer `with contexlib.suppress(SomeError): ...` But then the comment placement is less obvious. Your call.