Page MenuHomePhabricator

[electrum] fix opening Trezor settings menu while the device is locked
ClosedPublic

Authored by PiRK on Fri, Mar 21, 16:00.

Details

Summary

For some reason this feature is None when the device is locked, while all other features seem to be properly defined.
Don't raise an error dialog, just disable the passaphrase feature and add a tooltip to explain why it is disabled.

The error was:

    passphrases_label.setText(disen[features.passphrase_protection])
                              ~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
TypeError: list indices must be integers or slices, not NoneType
Test Plan

Open a Trezor wallet, lock the device, open the trezor setting menu (trezor logo in the bottom-right bar)

Diff Detail

Repository
rABC Bitcoin ABC
Branch
locked_trezor
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32797
Build 65082: Build Diffelectrum-tests
Build 65081: arc lint + arc unit