Users attempting to list XECX will see the "Redeem XECX?" confirmation modal due to a conditional rendering error. If the user has not selected the redeem XECX options, they should not see that modal.
Patch.
Details
Details
- Reviewers
PiRK - Group Reviewers
Restricted Project - Commits
- rABCceb4df3ac043: [Cashtab] Show the normal list workflow for XECX from the list option
npm test
npm start and list XECX. See the normal list modal and not the redeem modal.
this diff is live at https://cashtab-local-dev.netlify.app/
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- sell-xecx-patch
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 32820 Build 65128: Build Diff cashtab-tests Build 65127: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (cashtab-tests) failed.
Failed tests logs:
====== CashTab Unit Tests: <Token /> available actions rendered We can redeem 1 Firma for $1 of XEC using a workflow unique to Firma ======
Error: Unable to find an element with the text: List FIRMA?. This could be because the text is broken up by multiple elements. In this case, you can provide a function for your text matcher to make your matcher more flexible.
Ignored nodes: comments, script, style
<body>
<div>
<div
class="sc-keFjpB fuvsSf"
>
<section
aria-atomic="false"
aria-label="Notifications Alt+T"
aria-live="polite"
aria-relevant="additions text"
class="Toastify"
/>
<div
class="sc-jWojfa gOMhPW"
>
<div
class="sc-kVrTmx dSIcDd"
>
<div
class="sc-ivVeuv hQBWoJ"
>
<img
alt="cashtab"
class="sc-cCbXAZ jOUSPN"
src="test-file-stub"
/>
</div>
<div
class="sc-cmIlrE ckvYmi"
>
<div
class="sc-jkCMRl gxKbjs"
>
<select
class="sc-crNyjn bXFivV"
data-testid="wallet-select"
id="wallets"
name="wallets"
>
<option
class="sc-cpHetk jodErs"
value="Token Test"
>
Token Test
</option>
</select>
<div
class="sc-bqjOQT kauMuv"
>
<button
aria-label="Copy ecash:qqq9f9z3uhpzkxrgdjkd7dxuuey7tmpmugpmnw0kue"
class="sc-cJSrbW kZNvLw"
>
<svg
title="copy-paste"
/>
</button>
<div
class="sc-eerKOB cvXwwv"
>
<div
class="sc-emmjRN bSWkUh"
>
<input
checked=""
class="sc-gFaPwZ iPJMNd"
id="show-hide-balance"
name="show-hide-balance"
title="show-hide-balance"
type="checkbox"
/>
<label
class="sc-cpmLhU iUeRKn"
for="show-hide-balance"
>
<span
class="sc-dymIpo hGwQkt"
data-off=""
data-on=""
/>
<span
class="sc-bnXvFD cpOMDW"
/>
</label>
</div>
</div>
</div>
</div>
<div
class="sc-gleUXh fSfkBQ"
title="Wallet Info"
>
<div
class="sc-nrwXf erXBln"
>
<div
class="sc-eitiEO isWDMZ"
title="Balance XEC"
>
9,970.81
XEC
</div>
<div
class="sc-eitiEO gaHDhC"
title="Balance XECX"
>
10,000.00
<a
href="#/token/c67bf5c2b6d91cfb46a5c1772582eff80d88686887be10aa63b0945479cf4ed4"
>
XECX
</a>
</div>
<div
class="sc-eitiEO gaHDhC"
title="Balance FIRMA"
>
100.0000
<a
href="#/token/0387947fd575db4fb19a3e322f635dec37fd192b5941625b66bc4b2c3008cbf0"
>
FIRMA
</a>
</div>
</div>
<div
class="sc-bhlBdH kdHsOB"
title="Balance in Local Currency"
>
$
100.60
USD
</div>
<p
class="sc-AnqlK fLVAuQ"
title="Price in Local Currency"
>
1
XEC
=
0.00003000
USD
</p>
</div>
</div>
<div
class="sc-dTLGrV eQoClh"
>
<div
class="sc-jKVCRD kVWwbS"
>
<div
class="sc-fcdeBU chTKnN"
title="Token Stats"
>
<div
class="sc-RcBXQ kItXmO"
>
<button
class="sc-hzNEM eBXvVM"
>
<img
alt="icon for 0387947fd575db4fb19a3e322f635dec37fd192b5941625b66bc4b2c3008cbf0"
height="128"
...
at waitForWrapper (/work/cashtab/node_modules/@testing-library/dom/dist/wait-for.js:163:27)
at /work/cashtab/node_modules/@testing-library/dom/dist/query-helpers.js:86:33
at Object.findByText (/work/cashtab/src/components/Etokens/__tests__/TokenActions.test.js:2352:29)Each failure log is accessible here:
CashTab Unit Tests: <Token /> available actions rendered We can redeem 1 Firma for $1 of XEC using a workflow unique to Firma