[Cashtab] Streamline loading conditions in flaky test
ClosedPublic
Actions

Authored by bytesofman on Mon, Mar 31, 16:31.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC16124b0c2cfc: [Cashtab] Streamline loading conditions in flaky test

Summary

Seen this fail in CI. Remove the numerous conditional loading checks and instead use only a single async check for the condition we are specifically testing in this test.

Test Plan

npm test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

flaky-whitelist-test

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 32854
Build 65193: Build Diff	cashtab-tests
Build 65192: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mon, Mar 31, 16:31

Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Mar 31, 16:31

bytesofman published this revision for review.Mon, Mar 31, 16:34

Harbormaster completed remote builds in B32854: Diff 53311.Mon, Mar 31, 16:36

Fabien accepted this revision.Mon, Mar 31, 18:30

This revision is now accepted and ready to land.Mon, Mar 31, 18:30

Closed by commit rABC16124b0c2cfc: [Cashtab] Streamline loading conditions in flaky test (authored by bytesofman). · Explain WhyMon, Mar 31, 21:25

This revision was automatically updated to reflect the committed changes.

bytesofman added a commit: rABC16124b0c2cfc: [Cashtab] Streamline loading conditions in flaky test.

Revision Contents
Changeset List

Path

Size

cashtab/

src/

components/

Agora/

__tests__/

index.test.js

22 lines

Diff 53311

View Options

cashtab/src/components/Agora/tests/index.test.js

[Cashtab] Streamline loading conditions in flaky testClosedPublicActions