Page MenuHomePhabricator
Differential D17878

remove unused nChainSize
ClosedPublic
Actions

Authored by PiRK on Wed, Apr 2, 07:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8fd7122e4ec1: remove unused nChainSize
Summary

This stat is not used anywhere in the codebase. The getblockchaininfo already has a size_on_disk value that is arguably more useful for users.

Test Plan

ninja all check-all bitcoin-fuzzers

Diff Detail

Event Timeline

PiRK created this revision.Wed, Apr 2, 07:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 2, 07:50
PiRK requested review of this revision.Wed, Apr 2, 07:50
PiRK updated this revision to Diff 53320.

comment fix

PiRK added a child revision: D17872: block index: split ResetChainStats from UpdateChainStats.Wed, Apr 2, 08:04
Harbormaster completed remote builds in B32861: Diff 53319.Wed, Apr 2, 08:09
Harbormaster completed remote builds in B32862: Diff 53320.Wed, Apr 2, 08:16
PiRK updated this revision to Diff 53324.Wed, Apr 2, 09:38
PiRK edited the test plan for this revision. (Show Details)

fix fuzzer and add compiling bitcoin-fuzzers to test plan

Harbormaster completed remote builds in B32865: Diff 53324.Wed, Apr 2, 09:52
Fabien accepted this revision.Wed, Apr 2, 14:39
This revision is now accepted and ready to land.Wed, Apr 2, 14:39
Closed by commit rABC8fd7122e4ec1: remove unused nChainSize (authored by PiRK). · Explain WhyWed, Apr 2, 19:46
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC8fd7122e4ec1: remove unused nChainSize.
PiRK mentioned this in D17938: inline chain stats updating.Wed, Apr 16, 11:44
PiRK mentioned this in rABC01b4aa9a8761: inline chain stats updating.Thu, Apr 17, 11:10

Revision Contents
Changeset List

PathSize
src/
14 lines
13 lines
node/
1 line
test/
fuzz/
2 lines
1 line

Diff 53324

View Options

src/blockindex.h

Loading...
View Options

src/blockindex.cpp

Loading...
View Options

src/node/blockstorage.cpp

Loading...
View Options

src/test/fuzz/chain.cpp

Loading...
View Options

src/validation.cpp

Loading...