Page MenuHomePhabricator
Differential D17894

validation: indexing changes for assumeutxo
ClosedPublic
Actions

Authored by PiRK on Fri, Apr 4, 12:50.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC963062a18938: validation: indexing changes for assumeutxo
Summary

When using an assumedvalid chainstate, only process validationinterface
callbacks from the background chainstate within indexes. This ensures
that all indexes are built in-order.

Later, we can possibly designate indexes which can be built out of order
and continue their operation during snapshot use.

Once the background sync has completed, restart the indexes so that
they continue to index the now-validated snapshot chainstate.

This is a partial backport of core#27596
https://github.com/bitcoin/bitcoin/pull/27596/commits/373cf91531b84bfdd06fdf8abf4dca228029ce6b

For now the support for chronik is minimal: the indexer only indexes the IBD chain and ignores the snapshot callbacks, so that everything is indexed in the right order. But when the background chain reaches the snapshot base, indexing will just stop and a node restart will be necessary for it to resume (then the chain are merged and there is no longer a snapshot chain).

Test Plan

ninja all check-all

Full IDB with assumeutxo and indexers enabled (except for Chronik)

Diff Detail

Event Timeline

PiRK created this revision.Fri, Apr 4, 12:50
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Apr 4, 12:50
PiRK requested review of this revision.Fri, Apr 4, 12:50
teamcity edited the summary of this revision. (Show Details)Fri, Apr 4, 12:50
Harbormaster completed remote builds in B32893: Diff 53371.Fri, Apr 4, 13:13
PiRK added a child revision: D17895: validation: pruning for multiple chainstates.Fri, Apr 4, 13:24
Fabien requested changes to this revision.Mon, Apr 7, 09:32
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/index/base.cpp
83

you should move this code below and avoid the double cs_main lock

src/init.cpp
3070

Same here

This revision now requires changes to proceed.Mon, Apr 7, 09:32
PiRK added inline comments.Mon, Apr 7, 10:26
src/init.cpp
3070

This instance would require duplicating the code in both the for loop and if branch below, as the lock is taken inside the loop.

PiRK updated this revision to Diff 53394.Mon, Apr 7, 10:50

avoid taking the lock twice in base.cpp

Harbormaster completed remote builds in B32910: Diff 53394.Mon, Apr 7, 11:19
Fabien accepted this revision.Mon, Apr 7, 11:41
Fabien added inline comments.
src/init.cpp
3070

Is there a reason for releasing the lock at every loop increment ? Locking (especially cs_main) is generally slow

This revision is now accepted and ready to land.Mon, Apr 7, 11:41
Closed by commit rABC963062a18938: validation: indexing changes for assumeutxo (authored by James O'Beirne <james.obeirne@gmail.com>, committed by PiRK). · Explain WhyMon, Apr 7, 13:56
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC963062a18938: validation: indexing changes for assumeutxo.

Revision Contents
Changeset List

PathSize
chronik/
chronik-cpp/
18 lines
7 lines
src/
index/
12 lines
34 lines
33 lines
14 lines
19 lines

Diff 53371

View Options

chronik/chronik-cpp/chronik_bridge.cpp

Loading...
View Options

chronik/chronik-cpp/chronik_validationinterface.cpp

Loading...
View Options

src/index/base.h

Loading...
View Options

src/index/base.cpp

Loading...
View Options

src/init.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...