Page MenuHomePhabricator

tests: Don't make any wallets unless wallet is required
ClosedPublic

Authored by PiRK on Mon, Apr 7, 12:47.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
wallet_functional_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 32912
Build 65308: Build Diffbuild-without-wallet · build-clang-tidy · build-clang · build-debug · build-diff
Build 65307: arc lint + arc unit

Event Timeline

PiRK requested review of this revision.Mon, Apr 7, 12:47
test/functional/test_framework/test_framework.py
314–316

moving this does not make a difference in the end, it was needed for an intermediate step when self.requires_wallet = True was set in some tests in the set_test_params method.

I kept it because I think it is still a good thing to have self.config defined as early as possible. It will maybe avoid some headaches trying to find why some future backports don't work in Bitcoin ABC when they work for Core.

This revision is now accepted and ready to land.Mon, Apr 7, 13:14