Paths

Table of Contentst

Differential D17907

wallet: Write best block to disk before backup
ClosedPublic
Actions

Authored by PiRK on Tue, Apr 8, 08:07.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC41543b6f550c: wallet: Write best block to disk before backup

Summary

This ensures that the best block is included in the backup which leads to a more consistent behavior when loading the backup.

This is a partial backport of core#30678
https://github.com/bitcoin/bitcoin/pull/30678/commits/7e3dbe4180cbeb65e59b53d9fa98509e9189549d
https://github.com/bitcoin/bitcoin/pull/30678/commits/037b101e808ccf9e717751619e04f6e87d614efd

Depends on D17907

Test Plan

ninja all check-all
I also succesfully ran the wallet_assumeutxo.py test on my assumeutxo dev branch

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

PiRK created this revision.Tue, Apr 8, 08:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptTue, Apr 8, 08:07

PiRK requested review of this revision.Tue, Apr 8, 08:07

teamcity edited the summary of this revision. (Show Details)Tue, Apr 8, 08:07

PiRK edited the summary of this revision. (Show Details)Tue, Apr 8, 08:10

Harbormaster completed remote builds in B32918: Diff 53410.Tue, Apr 8, 08:26

Fabien accepted this revision.Tue, Apr 8, 09:27

This revision is now accepted and ready to land.Tue, Apr 8, 09:27

Closed by commit rABC41543b6f550c: wallet: Write best block to disk before backup (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain WhyTue, Apr 8, 10:31

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC41543b6f550c: wallet: Write best block to disk before backup.

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

9 lines

test/

functional/

wallet_backup.py

24 lines

Diff 53414

View Options

src/wallet/wallet.cpp