Page MenuHomePhabricator
Differential D17946

rpc, refactor: clean-up `addnode`
ClosedPublic
Actions

Authored by PiRK on Thu, Apr 17, 15:12.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC159c0dc33237: rpc, refactor: clean-up `addnode`
Summary
  1. Use const where possible;
  2. Rename variables to make them clearer;
  3. There is no need to check whether command is null since it's a non-optional field.

Test that addnode with an invalid command should throw an error.

Make it clear in the doc that node in addnode refers to the node's address.

This is a backport of core#26366

Test Plan

ninja all check-all

Diff Detail

Event Timeline

PiRK created this revision.Thu, Apr 17, 15:12
Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, Apr 17, 15:12
PiRK requested review of this revision.Thu, Apr 17, 15:12
teamcity edited the summary of this revision. (Show Details)Thu, Apr 17, 15:12
Harbormaster completed remote builds in B33003: Diff 53536.Thu, Apr 17, 15:26
PiRK added a child revision: D17947: RPC: access RPC arguments by name.Thu, Apr 17, 15:29
Fabien added a subscriber: Fabien.Thu, Apr 17, 18:28
Fabien added inline comments.
src/rpc/net.cpp
367

const auto command = Arg<std::string>(1);

376

const auto node_arg = Arg<std::string>(0);

Fabien accepted this revision.Thu, Apr 17, 18:29

nvm

This revision is now accepted and ready to land.Thu, Apr 17, 18:29
Closed by commit rABC159c0dc33237: rpc, refactor: clean-up `addnode` (authored by brunoerg <brunoely.gc@gmail.com>, committed by PiRK). · Explain WhyThu, Apr 17, 20:26
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC159c0dc33237: rpc, refactor: clean-up `addnode`.

Revision Contents
Changeset List

PathSize
src/
rpc/
28 lines
test/
functional/
14 lines

Diff 53536

View Options

src/rpc/net.cpp

Loading...
View Options

test/functional/rpc_net.py

Loading...