Differential D17950

[avalanche] Fix stake contender unit test occasional failure
ClosedPublic
Actions

Authored by Fabien on Fri, Apr 18, 14:45.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCdc7fa3c5d71e: [avalanche] Fix stake contender unit test occasional failure

Summary

The sorting algo differs in the test from the node algo if the number of accepted contenders is > AVALANCHE_CONTENDER_MAX_POLLABLE, which is a rare event.

To reproduce you can reduce AVALANCHE_CONTENDER_MAX_POLLABLE to some small number (4 is a good value) and run the test in a loop, it should fail quickly without this patch.

Test Plan

for i in {1..100}; do echo "Trial $i" && ./src/avalanche/test/test-avalanche -t processor_tests/stake_contender_local_winners || break; done

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Fri, Apr 18, 14:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Apr 18, 14:45

Fabien requested review of this revision.Fri, Apr 18, 14:45

Harbormaster completed remote builds in B33013: Diff 53553.Fri, Apr 18, 14:57

PiRK accepted this revision.Fri, Apr 18, 19:16

This revision is now accepted and ready to land.Fri, Apr 18, 19:16

Closed by commit rABCdc7fa3c5d71e: [avalanche] Fix stake contender unit test occasional failure (authored by Fabien). · Explain WhyFri, Apr 18, 22:01

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABCdc7fa3c5d71e: [avalanche] Fix stake contender unit test occasional failure.

Revision Contents
Changeset List

Path

Size

src/

avalanche/

test/

processor_tests.cpp

5 lines

Diff 53555

View Options

src/avalanche/test/processor_tests.cpp

[avalanche] Fix stake contender unit test occasional failureClosedPublicActions