Page MenuHomePhabricator
Differential D17978

qt: Call setParent() in the parent's context
ClosedPublic
Actions

Authored by Fabien on Wed, Apr 23, 10:46.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCa15e4d48be9a: qt: Call setParent() in the parent's context
Summary
The setParent(parent) internally calls QCoreApplication::sendEvent(parent, QChildEvent) that implies running in the thread which created the parent object. That is not the case always, and an internal assertion fails in the debug mode.

Backport of core#18948.
with changes from core-gui#587

Test Plan
ninja all check-all

Diff Detail

Event Timeline

Fabien created this revision.Wed, Apr 23, 10:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 23, 10:46
Fabien requested review of this revision.Wed, Apr 23, 10:46
teamcity edited the summary of this revision. (Show Details)Wed, Apr 23, 10:46
Harbormaster completed remote builds in B33064: Diff 53631.Wed, Apr 23, 11:11
PiRK accepted this revision.Wed, Apr 23, 11:34
PiRK edited the summary of this revision. (Show Details)
This revision is now accepted and ready to land.Wed, Apr 23, 11:35
Closed by commit rABCa15e4d48be9a: qt: Call setParent() in the parent's context (authored by Fabien). · Explain WhyWed, Apr 23, 14:00
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCa15e4d48be9a: qt: Call setParent() in the parent's context.

Revision Contents
Changeset List

PathSize
src/
qt/
16 lines

Diff 53631

View Options

src/qt/walletcontroller.cpp

Loading...