Page MenuHomePhabricator
Differential D17985

rpc: Optimize serialization disk space of dumptxoutset
ClosedPublic
Actions

Authored by PiRK on Wed, Apr 23, 19:46.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf23054071280: rpc: Optimize serialization disk space of dumptxoutset
Summary

Co-authored-by: Aurèle Oulès <aurele@oules.com>
Co-authored-by: TheCharlatan <seb.kung@gmail.com>

This is a partial backport of core#29612
https://github.com/bitcoin/bitcoin/pull/29612/commits/de95953d870c41436de67d56c93259bc66fe1434
https://github.com/bitcoin/bitcoin/pull/29612/commits/c14ed7f384075330361df636f40121cf25a066d6
https://github.com/bitcoin/bitcoin/pull/29612/commits/4d8e5edbaa94805be41ae4c8aa2f4bf7aaa276fe

Test Plan

ninja all check-all

add a assume utxo checkpoint, dump the corresponding utxo set, start a fresh node, load the utxo set and let it fully validate

Diff Detail

Event Timeline

PiRK created this revision.Wed, Apr 23, 19:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Apr 23, 19:46
teamcity edited the summary of this revision. (Show Details)Wed, Apr 23, 19:46
Harbormaster completed remote builds in B33083: Diff 53657.Wed, Apr 23, 19:49
teamcity added a comment.Wed, Apr 23, 19:49
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[402/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[403/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[404/582] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[405/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[406/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[407/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[408/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[409/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[410/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[411/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[412/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[413/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[414/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[415/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[416/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[417/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[418/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[419/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[420/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[421/582] Building CXX object src/CMakeFiles/server.dir/rpc/txoutproof.cpp.o
[422/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[423/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[424/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[425/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[426/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[427/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[428/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[429/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[430/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[431/582] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[432/582] Building CXX object src/CMakeFiles/server.dir/rpc/mempool.cpp.o
[433/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[434/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[435/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[436/582] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[437/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[438/582] Linking CXX static library src/wallet/libwallet.a
[439/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[440/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[441/582] Linking CXX executable src/iguana/iguana
[442/582] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-clang/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c /work/src/validation.cpp
/work/src/validation.cpp:6731:38: error: comparison of integers of different signs: 'uint32_t' (aka 'unsigned int') and 'int' [-Werror,-Wsign-compare]
                if (coin.GetHeight() > base_height ||
                    ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
1 error generated.
[443/582] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[444/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[445/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[446/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[447/582] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[448/582] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[449/582] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[450/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[451/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[452/582] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[453/582] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Wed, Apr 23, 19:49
Build Bitcoin ABC Diffs / Diff Testing (build-debug) failed.

Tail of the build log:

[403/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[404/582] Building CXX object src/CMakeFiles/server.dir/script/scriptcache.cpp.o
[405/582] Building CXX object src/CMakeFiles/server.dir/rpc/misc.cpp.o
[406/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[407/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[408/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[409/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[410/582] Building CXX object src/CMakeFiles/server.dir/rpc/server_util.cpp.o
[411/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[412/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[413/582] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[414/582] Building CXX object src/CMakeFiles/server.dir/rpc/txoutproof.cpp.o
[415/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[416/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[417/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[418/582] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[419/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[420/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[421/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[422/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[423/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[424/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[425/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[426/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[427/582] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[428/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[429/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[430/582] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[431/582] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[432/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[433/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[434/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[435/582] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[436/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[437/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[438/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[439/582] Linking CXX executable src/iguana/iguana
[440/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[441/582] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[442/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[443/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[444/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[445/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[446/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[447/582] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DABORT_ON_FAILED_ASSUME -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DDEBUG -DDEBUG_LOCKORDER -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-debug/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-debug/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -O0 -fPIC -fvisibility=hidden -g3 -ftrapv -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c /work/src/validation.cpp
/work/src/validation.cpp: In member function ‘bool ChainstateManager::PopulateAndValidateSnapshot(Chainstate&, AutoFile&, const node::SnapshotMetadata&)’:
/work/src/validation.cpp:6731:38: error: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
 6731 |                 if (coin.GetHeight() > base_height ||
      |                     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
[448/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[449/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[450/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[451/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[452/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[453/582] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1
teamcity added a comment.Wed, Apr 23, 19:50
Build Bitcoin ABC Diffs / Diff Testing (build-without-wallet) failed.

Tail of the build log:

[515/656] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[516/656] Linking C executable src/secp256k1/internal-bench
[517/656] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[518/656] Linking C executable src/secp256k1/sign-bench
[519/656] Linking CXX static library src/libscript.a
[520/656] Linking C executable src/secp256k1/ecmult-bench
[521/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[522/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[523/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[524/656] Building CXX object src/CMakeFiles/bitcoinkernel.dir/script/scriptcache.cpp.o
[525/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[526/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[527/656] Linking CXX static library src/libcommon.a
[528/656] Linking CXX shared library src/libbitcoinconsensus.so.0.31.2
[529/656] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[530/656] Linking CXX executable src/bitcoin-cli
[531/656] Linking CXX executable src/bitcoin-tx
[532/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[533/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[534/656] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[535/656] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[536/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[537/656] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[538/656] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[539/656] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[540/656] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[541/656] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[542/656] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[543/656] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[544/656] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[545/656] Linking CXX executable src/iguana/iguana
[546/656] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/proof.cpp.o
[547/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[548/656] Building CXX object src/CMakeFiles/bitcoinkernel.dir/node/blockstorage.cpp.o
[549/656] Building CXX object src/CMakeFiles/bitcoin-chainstate.dir/bitcoin-chainstate.cpp.o
[550/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[551/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[552/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[553/656] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[554/656] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[555/656] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/peermanager.cpp.o
[556/656] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-without-wallet/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c /work/src/validation.cpp
/work/src/validation.cpp: In member function ‘bool ChainstateManager::PopulateAndValidateSnapshot(Chainstate&, AutoFile&, const node::SnapshotMetadata&)’:
/work/src/validation.cpp:6731:38: error: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
 6731 |                 if (coin.GetHeight() > base_height ||
      |                     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
[557/656] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[558/656] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
FAILED: src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_CONFIG_H -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/. -I/work/src/leveldb/helpers/memenv -I/work/abc-ci-builds/build-without-wallet/src -I/work/abc-ci-builds/build-without-wallet/src/crypto/.. -I/work/src/univalue/include -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o -MF src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o.d -o src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o -c /work/src/validation.cpp
/work/src/validation.cpp: In member function ‘bool ChainstateManager::PopulateAndValidateSnapshot(Chainstate&, AutoFile&, const node::SnapshotMetadata&)’:
/work/src/validation.cpp:6731:38: error: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
 6731 |                 if (coin.GetHeight() > base_height ||
      |                     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
teamcity added a comment.Wed, Apr 23, 19:50
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

                if (coin.GetHeight() > base_height ||
                    ~~~~~~~~~~~~~~~~ ^ ~~~~~~~~~~~
2152 warnings generated.
Suppressed 2151 warnings (2151 in non-user code).
Use -header-filter=.* to display errors from all non-system headers. Use -system-headers to display errors from system headers as well.
1 warning treated as error
[401/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[402/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[403/580] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[404/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[405/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[406/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[407/580] Building CXX object src/CMakeFiles/server.dir/rpc/mining.cpp.o
[408/580] Building CXX object src/CMakeFiles/server.dir/rpc/net.cpp.o
[409/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[410/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[411/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[412/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[413/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[414/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[415/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[416/580] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[417/580] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[418/580] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[419/580] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[420/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[421/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[422/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[423/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[424/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[425/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[426/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[427/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[428/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[429/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[430/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[431/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[432/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[433/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[434/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[436/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[437/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[439/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[440/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[441/580] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[442/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[443/580] Linking CXX executable src/iguana/iguana
[444/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[445/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[446/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[447/580] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[448/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[449/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[450/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[451/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[452/580] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
teamcity added a comment.Wed, Apr 23, 19:50
Build Bitcoin ABC Diffs / Diff Testing (build-diff) failed.

Tail of the build log:

[403/582] Linking C executable src/secp256k1/ecmult-bench
[404/582] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[405/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[406/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[407/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[408/582] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[409/582] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[410/582] Linking CXX executable src/bitcoin-tx
[411/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[412/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[413/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[414/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[415/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[416/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[417/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[418/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[419/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[420/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[421/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[422/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[423/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[424/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[425/582] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[426/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[427/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[428/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[429/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[430/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[431/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[432/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[433/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[434/582] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
FAILED: src/CMakeFiles/server.dir/validation.cpp.o 
/usr/bin/ccache /usr/bin/c++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-diff/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-diff/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-reuse=none -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wredundant-decls -Wsign-compare -Wduplicated-branches -Wduplicated-cond -Wlogical-op -Wformat-security -Wredundant-move -Woverloaded-virtual -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/validation.cpp.o -MF src/CMakeFiles/server.dir/validation.cpp.o.d -o src/CMakeFiles/server.dir/validation.cpp.o -c /work/src/validation.cpp
/work/src/validation.cpp: In member function ‘bool ChainstateManager::PopulateAndValidateSnapshot(Chainstate&, AutoFile&, const node::SnapshotMetadata&)’:
/work/src/validation.cpp:6731:38: error: comparison of integer expressions of different signedness: ‘uint32_t’ {aka ‘unsigned int’} and ‘int’ [-Werror=sign-compare]
 6731 |                 if (coin.GetHeight() > base_height ||
      |                     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~
cc1plus: all warnings being treated as errors
[435/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[436/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[437/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[438/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[439/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[440/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[441/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[442/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[443/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[444/582] Linking CXX executable src/iguana/iguana
[445/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[446/582] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[447/582] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[448/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[449/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[450/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[451/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[452/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[453/582] Linking CXX static library src/wallet/libwallet.a
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1
PiRK updated this revision to Diff 53662.Thu, Apr 24, 10:36

fix cast

Harbormaster completed remote builds in B33086: Diff 53662.Thu, Apr 24, 10:38
teamcity added a comment.Thu, Apr 24, 10:38
Build Bitcoin ABC Diffs / Diff Testing (build-clang) failed.

Tail of the build log:

[412/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[413/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[414/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[415/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[416/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[417/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[418/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[419/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[420/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[421/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[422/582] Installing component secp256k1
-- Install configuration: "RelWithDebInfo"
-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[423/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[424/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[425/582] Linking C executable src/secp256k1/recover-bench
[426/582] Linking C executable src/secp256k1/sign-bench
[427/582] Linking CXX static library src/libbitcoinconsensus.a
[428/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[429/582] Linking C executable src/secp256k1/verify-bench
[430/582] Linking C executable src/secp256k1/internal-bench
[431/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[432/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[433/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[434/582] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[436/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[437/582] Linking C executable src/secp256k1/ecmult-bench
[438/582] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[439/582] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[440/582] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[441/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[442/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[443/582] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[444/582] Linking CXX static library src/libscript.a
[445/582] Linking CXX static library src/libcommon.a
[446/582] Linking CXX shared library src/libbitcoinconsensus.so.0.31.2
[447/582] Creating library symlink src/libbitcoinconsensus.so.0 src/libbitcoinconsensus.so
[448/582] Linking CXX executable src/bitcoin-cli
[449/582] Linking CXX executable src/iguana/iguana
[450/582] Linking CXX executable src/bitcoin-tx
[451/582] Linking CXX static library src/wallet/libwallet.a
[452/582] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
FAILED: src/CMakeFiles/server.dir/rpc/blockchain.cpp.o 
/usr/bin/ccache /usr/bin/clang++ -DBOOST_ALL_NO_LIB -DBOOST_NO_CXX98_FUNCTION_BASE -DBUILD_BITCOIN_INTERNAL -DENABLE_AVX2 -DENABLE_SHANI -DENABLE_SSE41 -DHAVE_BUILD_INFO -DHAVE_CONFIG_H -DHAVE_CONSENSUS_LIB -DLEVELDB_ATOMIC_PRESENT -DLEVELDB_PLATFORM_POSIX -DOS_LINUX -I/work/src/leveldb/helpers/memenv -I/work/src/. -I/work/abc-ci-builds/build-clang/src -I/work/src/univalue/include -I/work/abc-ci-builds/build-clang/src/crypto/.. -I/work/src/secp256k1/include -I/work/src/leveldb/include -isystem /usr/include/jemalloc -isystem /usr/include/miniupnpc -Werror -g -O2 -fPIC -fvisibility=hidden -fstack-protector-all -Wstack-protector -fcf-protection=full -fstack-clash-protection -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2 -Wall -Wextra -Wformat -Wgnu -Wvla -Wcast-align -Wunused-parameter -Wmissing-braces -Wthread-safety -Wrange-loop-analysis -Wredundant-decls -Wunreachable-code-loop-increment -Wsign-compare -Wconditional-uninitialized -Wdocumentation -Wformat-security -Wredundant-move -Woverloaded-virtual -Wshadow -Wshadow-field -Wno-unused-parameter -Wno-implicit-fallthrough -Wno-psabi -std=gnu++17 -MD -MT src/CMakeFiles/server.dir/rpc/blockchain.cpp.o -MF src/CMakeFiles/server.dir/rpc/blockchain.cpp.o.d -o src/CMakeFiles/server.dir/rpc/blockchain.cpp.o -c /work/src/rpc/blockchain.cpp
/work/src/rpc/blockchain.cpp:2753:34: error: declaration shadows a local variable [-Werror,-Wshadow]
            for (const auto &[n, coin] : coins) {
                                 ^
/work/src/rpc/blockchain.cpp:2735:10: note: previous declaration is here
    Coin coin;
         ^
1 error generated.
[453/582] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1
teamcity added a comment.Thu, Apr 24, 10:39
Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[395/580] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[396/580] Building CXX object src/CMakeFiles/server.dir/txpool.cpp.o
[397/580] Linking CXX executable src/bitcoin-cli
[398/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[399/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[400/580] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[401/580] Linking CXX executable src/bitcoin-tx
[402/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[403/580] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[404/580] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[405/580] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[406/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[407/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[408/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[409/580] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[410/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[411/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[412/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[413/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[414/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[415/580] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[416/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[417/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[418/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[419/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[420/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[421/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[422/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[423/580] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[424/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[425/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[426/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[427/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[428/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[429/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[430/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[431/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[432/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[433/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[434/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[435/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[436/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[437/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[438/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[439/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[440/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[441/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[442/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[443/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[444/580] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[445/580] Linking CXX executable src/iguana/iguana
[446/580] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[447/580] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[448/580] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[449/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[450/580] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[451/580] Linking CXX static library src/wallet/libwallet.a
[452/580] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1
PiRK updated this revision to Diff 53663.Thu, Apr 24, 10:52

don't shadow coin

Harbormaster completed remote builds in B33087: Diff 53663.Thu, Apr 24, 11:00
PiRK published this revision for review.Thu, Apr 24, 11:46
Fabien accepted this revision.Thu, Apr 24, 12:31
This revision is now accepted and ready to land.Thu, Apr 24, 12:31
Closed by commit rABCf23054071280: rpc: Optimize serialization disk space of dumptxoutset (authored by Fabian Jahr <fjahr@protonmail.com>, committed by PiRK). · Explain WhyThu, Apr 24, 14:06
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABCf23054071280: rpc: Optimize serialization disk space of dumptxoutset.

Revision Contents
Changeset List

PathSize
src/
rpc/
46 lines
test/
9 lines
6 lines
133 lines
test/
functional/
27 lines
2 lines

Diff 53662

View Options

src/rpc/blockchain.cpp

Loading...
View Options

src/test/validation_chainstatemanager_tests.cpp

Loading...
View Options

src/validation.h

Loading...
View Options

src/validation.cpp

Loading...
View Options

test/functional/feature_assumeutxo.py

Loading...
View Options

test/functional/rpc_dumptxoutset.py

Loading...