Page MenuHomePhabricator
Differential D17997

[avalanche] Fix staking reward flakiness after node restart in contenders test
ClosedPublic
Actions

Authored by roqqit on Fri, Apr 25, 20:13.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC8ed7061ec857: [avalanche] Fix staking reward flakiness after node restart in contenders test
Summary

Staking rewards may not be ready and trying to force them to be ready via setmocktime after restarting the node causes the prior quorum's proofs to be removed for dangling too long. Instead, we can check if staking rewards is ready and verify the respective poll response. Either PENDING or ACCEPTED are reasonable for our purposes here.

Test Plan
./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Event Timeline

roqqit created this revision.Fri, Apr 25, 20:13
Herald added a reviewer: Restricted Project. · View Herald TranscriptFri, Apr 25, 20:13
roqqit requested review of this revision.Fri, Apr 25, 20:13
Harbormaster completed remote builds in B33112: Diff 53701.Fri, Apr 25, 20:25
PiRK added a child revision: D17998: RPC: Extract InvalidateBlock and ReconsiderBlock helpers.Sat, Apr 26, 06:41
Fabien accepted this revision.Sat, Apr 26, 09:01
This revision is now accepted and ready to land.Sat, Apr 26, 09:01
Closed by commit rABC8ed7061ec857: [avalanche] Fix staking reward flakiness after node restart in contenders test (authored by roqqit). · Explain WhySat, Apr 26, 20:50
This revision was automatically updated to reflect the committed changes.
roqqit added a commit: rABC8ed7061ec857: [avalanche] Fix staking reward flakiness after node restart in contenders test.
roqqit mentioned this in D18003: [avalanche] Fix incomplete testing of contenders when staking rewards are active.Sun, Apr 27, 02:05
PiRK removed a child revision: D17998: RPC: Extract InvalidateBlock and ReconsiderBlock helpers.Wed, Apr 30, 06:08
Fabien mentioned this in D18036: [avalanche] Fix incomplete testing of contenders when staking rewards are active.Wed, Apr 30, 20:01
roqqit mentioned this in rABC029da727864b: [avalanche] Fix incomplete testing of contenders when staking rewards are active.Thu, May 1, 18:22

Revision Contents
Changeset List

PathSize
test/
functional/
26 lines

Diff 53701

View Options

test/functional/abc_p2p_avalanche_contender_voting.py

Loading...