Differential D18039

[test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting
ClosedPublic
Actions

Authored by Fabien on Thu, May 1, 12:03.

Tags

None

Subscribers

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC895953381351: [test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting

Summary

This will avoid having the polling slots filled with blocks, making the test slower and flaky.
Because this adds some rounds of vote we need to increase the stale factor to avoid stalling contenders prematurely.

This is a step towards fixing the test flakiness.

Depends on D18038.

Test Plan

./test/functional/test_runner.py abc_p2p_avalanche_contender_voting

Diff Detail

Repository

rABC Bitcoin ABC

Branch

finalize_tip_contenders

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33189
Build 65861: Build Diff	build-diff · build-debug · build-without-wallet · build-clang-tidy · build-clang
Build 65860: arc lint + arc unit

Event Timeline

Fabien created this revision.Thu, May 1, 12:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptThu, May 1, 12:03

Fabien requested review of this revision.Thu, May 1, 12:03

Fabien added a child revision: D18040: [test] Only activate the quorum after all the peers are connected.Thu, May 1, 12:07

Harbormaster completed remote builds in B33189: Diff 53809.Thu, May 1, 12:12

roqqit accepted this revision.Thu, May 1, 15:57

roqqit added a subscriber: roqqit.

roqqit added inline comments.

test/functional/abc_p2p_avalanche_contender_voting.py
154–168	nit: unnecessary nesting

This revision is now accepted and ready to land.Thu, May 1, 15:57

Closed by commit rABC895953381351: [test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting (authored by Fabien). · Explain WhyThu, May 1, 16:38

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC895953381351: [test] Finalize the tip when possible in abc_p2p_avalanche_contender_voting.

Revision Contents
Changeset List

Path

Size

test/

functional/

abc_p2p_avalanche_contender_voting.py

30 lines

Diff 53809

test/functional/abc_p2p_avalanche_contender_voting.py

Loading...