Page MenuHomePhabricator
Differential D18044

[Cashtab] Load FIRMA agora page with price in fiat instead of XEC
ClosedPublic
Actions

Authored by bytesofman on Sat, May 3, 21:45.

Details

Reviewers
emack
Group Reviewers
Restricted Project
Commits
rABC88d6844da3f2: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC
Summary

For FIRMA, it is more relevant to load the OrderBook in fiat prices than XEC. Do this by default.

Test Plan

npm test

Diff Detail

Repository
rABC Bitcoin ABC
Branch
firma-prices-usd
Lint
Lint Errors
SeverityLocationCodeMessage
Errorcashtab/src/components/Agora/OrderBook/index.tsx:101ESLINT@typescript-eslint/no-unused-vars
Unit
No Test Coverage
Build Status
Buildable 33205
Build 65893: Build Diffcashtab-tests
Build 65892: arc lint + arc unit

Event Timeline

bytesofman created this revision.Sat, May 3, 21:45
Herald added a reviewer: Restricted Project. · View Herald TranscriptSat, May 3, 21:45
bytesofman updated this revision to Diff 53841.Sat, May 3, 21:49

remove debug logs and unrelated line break

Harbormaster completed remote builds in B33203: Diff 53840.Sat, May 3, 21:50
Harbormaster completed remote builds in B33204: Diff 53841.Sat, May 3, 21:54
bytesofman updated this revision to Diff 53842.Sat, May 3, 22:09

apply to agora page as well

Harbormaster completed remote builds in B33205: Diff 53842.Sat, May 3, 22:09
bytesofman updated this revision to Diff 53843.Sat, May 3, 22:10

lint, improve comments

Harbormaster completed remote builds in B33206: Diff 53843.Sat, May 3, 22:16
bytesofman updated this revision to Diff 53844.Sat, May 3, 22:26

test the component as well

Harbormaster completed remote builds in B33207: Diff 53844.Sat, May 3, 22:31
bytesofman published this revision for review.Sat, May 3, 22:55
emack added a subscriber: emack.Sun, May 4, 02:03

@bot preview-cashtab

teamcity awarded a token.Sun, May 4, 02:03
teamcity added a comment.Sun, May 4, 02:06

Build Bitcoin ABC Diffs / Diff Testing (preview-cashtab) passed.
Preview is available at http://51.68.37.192:41160 for the next 60 minutes.

emack accepted this revision.Sun, May 4, 02:14
This revision is now accepted and ready to land.Sun, May 4, 02:14
Closed by commit rABC88d6844da3f2: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC (authored by bytesofman). · Explain WhySun, May 4, 03:22
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABC88d6844da3f2: [Cashtab] Load FIRMA agora page with price in fiat instead of XEC.

Revision Contents
Changeset List

PathSize
cashtab/
src/
components/
Agora/
OrderBook/
11 lines
fixtures/
49 lines
5 lines
Etokens/
Token/
1 line
__tests__/
31 lines

Diff 53842

View Options

cashtab/src/components/Agora/OrderBook/index.tsx

Loading...
View Options

cashtab/src/components/Agora/fixtures/mocks.ts

Loading...
View Options

cashtab/src/components/Agora/index.tsx

Loading...
View Options

cashtab/src/components/Etokens/Token/index.tsx

Loading...
View Options

cashtab/src/components/Etokens/__tests__/TokenActions.test.js

Loading...