Page MenuHomePhabricator
Differential D18084

[chronik-client] Properly handle txs ordering in the test
ClosedPublic
Actions

Authored by Fabien on Mon, May 12, 22:17.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABCe29827cea629: [chronik-client] Properly handle txs ordering in the test
Summary

Unconfirmed txs are sorted by time first seen, then txid.
Confirmed txs are sorted by txid.
History txs are sorted by reverse time first seen, then reverse txid.

Let's not assume the time is the same in the test, because time first seen is not mockable. Instead we actually perform the appropriated sort.

Test Plan
./contrib/teamcity/build-configurations.py chronik-client-integration-tests

Diff Detail

Event Timeline

Fabien created this revision.Mon, May 12, 22:17
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 12, 22:17
Fabien requested review of this revision.Mon, May 12, 22:17
Harbormaster completed remote builds in B33282: Diff 53960.Mon, May 12, 22:31
PiRK added a subscriber: PiRK.Tue, May 13, 06:03
PiRK added inline comments.
test/functional/setup_scripts/chronik-client_plugins.py
237–238
237–238
PiRK accepted this revision.Tue, May 13, 06:04

optional suggestions. The bytes flipping + explicit byteorder specification hurts my brain.

This revision is now accepted and ready to land.Tue, May 13, 06:04
Fabien added inline comments.Tue, May 13, 07:18
test/functional/setup_scripts/chronik-client_plugins.py
237–238

the idea was that "big" is the default after python 3.11 so it will eventually get removed, but you're right it's easier to read that way

Closed by commit rABCe29827cea629: [chronik-client] Properly handle txs ordering in the test (authored by Fabien). · Explain WhyTue, May 13, 07:20
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABCe29827cea629: [chronik-client] Properly handle txs ordering in the test.

Revision Contents
Changeset List

PathSize
modules/
chronik-client/
test/
integration/
61 lines
test/
functional/
setup_scripts/
36 lines

Diff 53960

View Options

modules/chronik-client/test/integration/plugins.ts

Loading...
View Options

test/functional/setup_scripts/chronik-client_plugins.py

Loading...