This is a requirement from the Electrum protocol.
Depends on D18087.
Details
Details
- Reviewers
- None
- Group Reviewers
Restricted Project
TBD
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- chronik_unconfirmed_parents
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 33343 Build 66167: Build Diff Build 66166: arc lint + arc unit
Event Timeline
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.
Tail of the build log:
Checking toml_datetime v0.6.8
Compiling pyo3 v0.23.3
Checking winnow v0.6.20
Checking sync_wrapper v0.1.2
Checking mime v0.3.17
Checking sync_wrapper v1.0.2
Checking topo_sort v0.4.0
Checking seahash v4.1.0
Checking axum-core v0.4.5
Checking tower v0.5.1
Checking hyper-util v0.1.10
Checking memoffset v0.9.1
Checking tokio-tungstenite v0.24.0
Checking serde_urlencoded v0.7.1
Compiling karyon_jsonrpc_macro v0.3.0
Checking futures-executor v0.3.31
Checking serde_path_to_error v0.1.16
Checking unindent v0.2.3
Checking base64 v0.22.1
Checking matchit v0.7.3
Checking unicode-segmentation v1.12.0
Checking futures v0.3.31
Checking tower-http v0.5.2
Compiling chronik-bridge v0.1.0 (/work/chronik/chronik-bridge)
Checking convert_case v0.6.0
Checking toml_edit v0.22.22
Compiling librocksdb-sys v0.11.0+8.1.1
Checking axum v0.7.9
Checking toml v0.8.19
Compiling pyo3-macros v0.23.3
Checking chronik-plugin-impl v0.1.0 (/work/chronik/chronik-plugin-impl)
Compiling aws-lc-rs v1.11.1
Compiling rustls v0.23.19
Checking rustls-webpki v0.102.8
Checking tokio-rustls v0.26.1
Checking karyon_async_rustls v0.3.0
Checking karyon_net v0.3.0
Checking karyon_jsonrpc v0.3.0
Checking rocksdb v0.21.0
Checking chronik-db v0.1.0 (/work/chronik/chronik-db)
Checking chronik-indexer v0.1.0 (/work/chronik/chronik-indexer)
Checking chronik-http v0.1.0 (/work/chronik/chronik-http)
error: unneeded `return` statement
--> chronik/chronik-http/src/electrum.rs:559:5
|
559 | return Ok(false);
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
559 - return Ok(false);
559 + Ok(false)
|
error: could not compile `chronik-http` (lib) due to 1 previous error
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
Tail of the build log:
Doc-tests chronik-bridge running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-db running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-http running 1 test test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.39s Doc-tests chronik-indexer running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-plugin running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-plugin-common running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-plugin-impl running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-proto running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-util running 2 tests test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s ninja: build stopped: cannot make progress due to previous errors. Build build-chronik-plugins failed with exit code 1
Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.
Tail of the build log:
Checking toml_datetime v0.6.8
Compiling pyo3 v0.23.3
Checking mime v0.3.17
Checking seahash v4.1.0
Checking winnow v0.6.20
Checking topo_sort v0.4.0
Checking sync_wrapper v1.0.2
Checking sync_wrapper v0.1.2
Checking tower v0.5.1
Checking axum-core v0.4.5
Checking hyper-util v0.1.10
Checking memoffset v0.9.1
Checking tokio-tungstenite v0.24.0
Checking serde_urlencoded v0.7.1
Checking futures-executor v0.3.31
Checking serde_path_to_error v0.1.16
Checking base64 v0.22.1
Checking matchit v0.7.3
Checking unindent v0.2.3
Compiling karyon_jsonrpc_macro v0.3.0
Checking unicode-segmentation v1.12.0
Checking tower-http v0.5.2
Checking futures v0.3.31
Compiling chronik-bridge v0.1.0 (/work/chronik/chronik-bridge)
Checking convert_case v0.6.0
Checking toml_edit v0.22.22
Compiling librocksdb-sys v0.11.0+8.1.1
Checking axum v0.7.9
Compiling pyo3-macros v0.23.3
Checking toml v0.8.19
Checking chronik-plugin-impl v0.1.0 (/work/chronik/chronik-plugin-impl)
Compiling aws-lc-rs v1.11.1
Compiling rustls v0.23.19
Checking rustls-webpki v0.102.8
Checking tokio-rustls v0.26.1
Checking karyon_async_rustls v0.3.0
Checking karyon_net v0.3.0
Checking karyon_jsonrpc v0.3.0
Checking rocksdb v0.21.0
Checking chronik-db v0.1.0 (/work/chronik/chronik-db)
Checking chronik-indexer v0.1.0 (/work/chronik/chronik-indexer)
Checking chronik-http v0.1.0 (/work/chronik/chronik-http)
error: unneeded `return` statement
--> chronik/chronik-http/src/electrum.rs:559:5
|
559 | return Ok(false);
| ^^^^^^^^^^^^^^^^
|
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#needless_return
= note: `-D clippy::needless-return` implied by `-D warnings`
= help: to override `-D warnings` add `#[allow(clippy::needless_return)]`
help: remove `return`
|
559 - return Ok(false);
559 + Ok(false)
|
error: could not compile `chronik-http` (lib) due to 1 previous error
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1Comment Actions
Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.
Tail of the build log:
Doc-tests chronik-bridge running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-db running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-http running 1 test test chronik/chronik-http/src/protobuf.rs - protobuf::Protobuf (line 29) ... ok test result: ok. 1 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.38s Doc-tests chronik-indexer running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-plugin running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-plugin-common running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-plugin-impl running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-proto running 0 tests test result: ok. 0 passed; 0 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s Doc-tests chronik-util running 2 tests test chronik/chronik-util/src/log.rs - log::log (line 65) ... ignored test chronik/chronik-util/src/log.rs - log::log_chronik (line 87) ... ignored test result: ok. 0 passed; 0 failed; 2 ignored; 0 measured; 0 filtered out; finished in 0.00s ninja: build stopped: cannot make progress due to previous errors. Build build-chronik-plugins failed with exit code 1