Page MenuHomePhabricator
Differential D18108

[chronik] Electrum: handle unconfirmed parents in history
ClosedPublic
Actions

Authored by Fabien on Mon, May 19, 08:51.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Commits
rABC66a28fe31da4: [chronik] Electrum: handle unconfirmed parents in history
Summary

This diff makes the chronik electrum history strictly compliant with the Electrum protocol, and also identical with Fulcrum ordering (because the protocol itself is not deterministic).
If this is found to be a problem in the future this can be revisited but for now we want to be a 1:1 replacement.

Depends on D18106 and D18107.

Test Plan
./test/functional/test_runner.py chronik_electrum_*

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

Fabien created this revision.Mon, May 19, 08:51
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, May 19, 08:51
Fabien requested review of this revision.Mon, May 19, 08:51
PiRK edited the summary of this revision. (Show Details)Mon, May 19, 08:56
Fabien added a child revision: D18087: [chronik] Add the blockchain.scripthash.subscribe endpoint.Mon, May 19, 09:07
Fabien updated this revision to Diff 54070.Mon, May 19, 09:17

Fix inaccurate coinbase comment

Fabien updated this revision to Diff 54077.Mon, May 19, 09:36

More robust handling of coinbase txs. This is unreachable code but this guards against future code changes.

Harbormaster completed remote builds in B33362: Diff 54070.Mon, May 19, 09:41
Fabien updated this revision to Diff 54078.Mon, May 19, 10:24

Revert the test change, it doesn't do what I expect and we already have coverage for coinbase in history a few lines above

Harbormaster completed remote builds in B33368: Diff 54077.Mon, May 19, 10:29
teamcity added a comment.Mon, May 19, 10:29
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
PiRK accepted this revision.Mon, May 19, 10:37
This revision is now accepted and ready to land.Mon, May 19, 10:37
Harbormaster completed remote builds in B33369: Diff 54078.Mon, May 19, 10:50
Closed by commit rABC66a28fe31da4: [chronik] Electrum: handle unconfirmed parents in history (authored by Fabien). · Explain WhyMon, May 19, 12:28
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC66a28fe31da4: [chronik] Electrum: handle unconfirmed parents in history.

Revision Contents
Changeset List

PathSize
chronik/
chronik-http/
src/
124 lines
test/
functional/
52 lines

Diff 54081

View Options

chronik/chronik-http/src/electrum.rs

Loading...
View Options

test/functional/chronik_electrum_blockchain.py

Loading...