Differential D18151

[chronik] Electrum: implement peer discovery endpoints
ClosedPublic
Actions

Authored by Fabien on May 26 2025, 13:25.

Tags

None

Subscribers

None

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rABC5796ee98b0b4: [chronik] Electrum: implement peer discovery endpoints

Summary

This adds the server.add_peer endpoint and use this data to return in peers.subscribe.

Peer validation is not implemented yet, which means that no added peers will end up in the subscribe returned list for now.

Test Plan

./test/functional/test_runner.py chronik_electrum_basic

Diff Detail

Repository

rABC Bitcoin ABC

Branch

chronik_peer_add

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33441
Build 66361: Build Diff	chronik-client-integration-tests · build-diff · ecash-agora-integration-tests · ecash-lib-integration-tests · build-clang-tidy · build-chronik-plugins · build-clang · build-debug · build-chronik · build-without-wallet
Build 66360: arc lint + arc unit

Event Timeline

Fabien created this revision.May 26 2025, 13:25

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 26 2025, 13:25

Fabien requested review of this revision.May 26 2025, 13:25

Fabien added a child revision: D18152: [chronik] Electrum: implement the banner endoint.May 26 2025, 13:43

Harbormaster completed remote builds in B33438: Diff 54188.May 26 2025, 13:51

Limit the peers list size, hardcoded to 10 for now. The peer validation will be responsible for clearing the list as well.

Harbormaster completed remote builds in B33441: Diff 54195.May 26 2025, 19:57

PiRK accepted this revision.May 27 2025, 06:46

This revision is now accepted and ready to land.May 27 2025, 06:46

Closed by commit rABC5796ee98b0b4: [chronik] Electrum: implement peer discovery endpoints (authored by Fabien). · Explain WhyMay 27 2025, 07:35

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rABC5796ee98b0b4: [chronik] Electrum: implement peer discovery endpoints.

Revision Contents
Changeset List

Path

Size

chronik/

chronik-http/

src/

161 lines

test/

functional/

chronik_electrum_basic.py

129 lines

Diff 54195

chronik/chronik-http/src/electrum.rs

Loading...

test/functional/chronik_electrum_basic.py

Loading...