[electrum] move format_amount* functions from main_window to amount.py
ClosedPublic
Actions

Authored by PiRK on Jul 3 2025, 11:33.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABCfede0f2728a6: [electrum] move format_amount* functions from main_window to amount.py

Summary

This does not need to be a method associated with a GUI window. Moving it to another module will reduce the dependencies on main_window by subwidgets of the main window.

Another small effort in making main_window less of a God object

Depends on D18316

Test Plan

python test_runner.py unit

Run Electrum ABC, check for no errors and look at some amounts (XEC and fiat), double-click on a transaction and on an address to open the modified dialogs

Diff Detail

Repository

rABC Bitcoin ABC

Branch

refactor_amin_window

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 33744
Build 66966: Build Diff	electrum-tests · electrum-functional-tests
Build 66965: arc lint + arc unit

Event Timeline

PiRK created this revision.Jul 3 2025, 11:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptJul 3 2025, 11:33

PiRK requested review of this revision.Jul 3 2025, 11:33

i'm missing someting in transaction_dialog

Harbormaster completed remote builds in B33743: Diff 54666.Jul 3 2025, 11:41

fix more occurences of subwidgets calling the main_window to format amounts

Harbormaster completed remote builds in B33744: Diff 54667.Jul 3 2025, 12:02

Fabien accepted this revision.Jul 3 2025, 13:55

Fabien added a subscriber: Fabien.

Fabien added inline comments.

electrum/electrumabc_gui/qt/transaction_dialog.py
641	out of scope for this diff, but at some point you might want to wrap all this in to an Amount class (similar to what the node does) that have various format methods. This will make sure that you don't have a type issue (passing value as XEC or sat when the opposite is expected)

This revision is now accepted and ready to land.Jul 3 2025, 13:55

Closed by commit rABCfede0f2728a6: [electrum] move format_amount* functions from main_window to amount.py (authored by PiRK). · Explain WhyJul 3 2025, 21:05

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABCfede0f2728a6: [electrum] move format_amount* functions from main_window to amount.py.

PiRK mentioned this in D18325: [electrum] move format_fee_rate to amount.py.Jul 4 2025, 09:54

PiRK mentioned this in rABCc1e03d985e4d: [electrum] move format_fee_rate to amount.py.Jul 5 2025, 10:04