Page MenuHomePhabricator
Differential D18554

[electrum] allow disabling SSL when using localhost electrum server
ClosedPublic
Actions

Authored by PiRK on Sep 1 2025, 08:35.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC4953305bfee8: [electrum] allow disabling SSL when using localhost electrum server
Summary

This makes testing the server easier, without having to patch the Electrum ABC code everytime. Just open the network dialog, type 127.0.0.1 in the host box, and then you can uncheck "Use SSL".

Test Plan
cmake -GNinja -DBUILD_CHRONIK
ninja
src/bitcoind -chronik -chronikelectrumbind=127.0.0.1:50001:t

Start Electrum ABC, connect to 127.0.0.1:50001 without SSL

Diff Detail

Repository
rABC Bitcoin ABC
Branch
electrum_tcp_connection
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34303
Build 68074: Build Diffelectrum-functional-tests · electrum-tests
Build 68073: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 1 2025, 08:35
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 1 2025, 08:35
PiRK requested review of this revision.Sep 1 2025, 08:35
Fabien requested changes to this revision.Sep 1 2025, 08:43
Fabien added a subscriber: Fabien.
Fabien added inline comments.
electrum/electrumabc_gui/qt/network_dialog.py
1050 ↗(On Diff #55452)

and host != "::1" and host != "localhost"

This revision now requires changes to proceed.Sep 1 2025, 08:43
Harbormaster completed remote builds in B34301: Diff 55452.Sep 1 2025, 08:43
PiRK updated this revision to Diff 55454.Sep 1 2025, 09:23

::1 and localhost

Fabien accepted this revision.Sep 1 2025, 09:32
This revision is now accepted and ready to land.Sep 1 2025, 09:32
Harbormaster completed remote builds in B34303: Diff 55454.Sep 1 2025, 09:32
Closed by commit rABC4953305bfee8: [electrum] allow disabling SSL when using localhost electrum server (authored by PiRK). · Explain WhySep 1 2025, 12:02
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC4953305bfee8: [electrum] allow disabling SSL when using localhost electrum server.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc_gui/
qt/
3 lines

Diff 55454

View Options

electrum/electrumabc_gui/qt/network_dialog.py

Loading...