refactor: rename fDoFullFlush to should_write
ClosedPublic
Actions

Authored by PiRK on Sep 16 2025, 12:58.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC9f6f7f0b56ad: refactor: rename fDoFullFlush to should_write

Summary

This is a partial backport of core#30611
https://github.com/bitcoin/bitcoin/pull/30611/commits/b557fa7a175f139614932fbb3a4ad0af8271c73c
Depends on D18640

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34469
Build 68406: Build Diff
Build 68405: arc lint + arc unit

Event Timeline

PiRK created this revision.Sep 16 2025, 12:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 16 2025, 12:58

PiRK requested review of this revision.Sep 16 2025, 12:58

teamcity edited the summary of this revision. (Show Details)Sep 16 2025, 12:59

PiRK added a child revision: D18642: refactor: replace m_last_write with m_next_write.Sep 16 2025, 13:00

PiRK planned changes to this revision.Sep 16 2025, 13:22

rebase

Harbormaster completed remote builds in B34479: Diff 55714.Sep 16 2025, 14:25

Fabien accepted this revision.Sep 17 2025, 16:22

This revision is now accepted and ready to land.Sep 17 2025, 16:22

Closed by commit rABC9f6f7f0b56ad: refactor: rename fDoFullFlush to should_write (authored by Andrew Toth <andrewstoth@gmail.com>, committed by PiRK). · Explain WhySep 17 2025, 18:26

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC9f6f7f0b56ad: refactor: rename fDoFullFlush to should_write.

Revision Contents
Changeset List

Path

Size

src/

validation.cpp

10 lines

Diff 55702

View Options

refactor: rename fDoFullFlush to should_writeClosedPublicActions