Page MenuHomePhabricator
Differential D18651

[electrum] bump RPC timeout
ClosedPublic
Actions

Authored by PiRK on Sep 19 2025, 13:29.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC01f8212cc08f: [electrum] bump RPC timeout
Summary

For addresses with a very large history, with a low-end server, the blockchain.scripthash.subscribe and blockchain.scripthash.get_history RPCs can take longer than 10 seconds.

Also use constants instead of magic numbers for timeouts.

Test Plan

Start syncing a very large wallet in Electrum ABC on a weak server, check that it manages to fetch the history

Diff Detail

Event Timeline

PiRK created this revision.Sep 19 2025, 13:29
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 19 2025, 13:29
PiRK requested review of this revision.Sep 19 2025, 13:29
Harbormaster completed remote builds in B34507: Diff 55755.Sep 19 2025, 13:37
bytesofman accepted this revision.Sep 19 2025, 18:20
bytesofman added a subscriber: bytesofman.
bytesofman added inline comments.
electrum/electrumabc/interface.py
126

is this still a magic number?

This revision is now accepted and ready to land.Sep 19 2025, 18:20
PiRK edited the summary of this revision. (Show Details)Sep 20 2025, 07:09
Closed by commit rABC01f8212cc08f: [electrum] bump RPC timeout (authored by PiRK). · Explain WhySep 22 2025, 11:05
This revision was automatically updated to reflect the committed changes.
PiRK added a commit: rABC01f8212cc08f: [electrum] bump RPC timeout.

Revision Contents
Changeset List

PathSize
electrum/
electrumabc/
11 lines

Diff 55755

View Options

electrum/electrumabc/interface.py

Loading...