Page MenuHomePhabricator
Differential D18675

[ecash-lib, cashtab] Expand parsing functions of ecash-lib
AbandonedPublic
Actions

Authored by bytesofman on Sep 24 2025, 03:32.

Details

Reviewers
PiRK
Group Reviewers
Restricted Project
Summary

Right now, we have cashtab-specific parsing of OP_RETURN in cashtab.

Desired end state is generic parsing of OP_RETURN for all spec'd OP_RETURN use on the eCash network, also with a standard way of handling unknown spec or off-spec usage.

Cashtab has the most mature parsing, so we use it as a starting point.

Add OP_RETURN and EMPP parsing to ecash-lib. Suggest an interface for ParsedOpReturn, a general type for parsing a string OP_RETURN as returned in a chronik Tx

We intentionally do not bump the version of ecash-lib, as this is still WIP. Will hold off until we have a portable and useful full parseOpReturn function.

Test Plan

npm test, CI

Diff Detail

Event Timeline

bytesofman created this revision.Sep 24 2025, 03:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptSep 24 2025, 03:32
Harbormaster completed remote builds in B34557: Diff 55829.Sep 24 2025, 03:32
bytesofman updated this revision to Diff 55839.Sep 24 2025, 12:46

lint, clean up tests, better organization, remove tests from cashtab for fns tested in ecash-lib

Harbormaster completed remote builds in B34564: Diff 55839.Sep 24 2025, 13:16
bytesofman published this revision for review.Sep 24 2025, 13:18
bytesofman edited the summary of this revision. (Show Details)
PiRK added a subscriber: PiRK.Sep 26 2025, 06:28

OK, I checked that the getEmppAppAction, getEmppAppActions & getXecxAppAction related changes are move-only (with some blank line changes and some const renaming, eg opReturn.appPrefixesHex.xecx -> EMPP_APP_PREFIXES.XECX).
The API of the new stuff (ParsedOpReturn, parseOpReturn) makes senses to me.

PiRK accepted this revision.Sep 26 2025, 06:28
This revision is now accepted and ready to land.Sep 26 2025, 06:28
bytesofman added a comment.Sun, Oct 26, 17:30

dropped the ball on this. now i have some more actions to add if I keep it this way. But, imo, the API needs some more thought....will revisit this after getting ecash-wallet into Cashtab

bytesofman abandoned this revision.Sun, Oct 26, 17:30

Revision Contents
Changeset List

PathSize
cashtab/
src/
chronik/
3 lines
opreturn/
__tests__/
4 lines
145 lines
modules/
ecash-lib/
src/
2 lines
parse/
51 lines
260 lines
161 lines
39 lines
56 lines

Diff 55829

View Options

cashtab/src/chronik/index.ts

Loading...
View Options

cashtab/src/opreturn/__tests__/index.test.js

Loading...
View Options

cashtab/src/opreturn/index.ts

Loading...
View Options

modules/ecash-lib/src/index.ts

Loading...
View Options

modules/ecash-lib/src/parse/apps.ts

Loading...
View Options

modules/ecash-lib/src/parse/empp.test.ts

Loading...
View Options

modules/ecash-lib/src/parse/empp.ts

Loading...
View Options

modules/ecash-lib/src/parse/opreturn.test.ts

Loading...
View Options

modules/ecash-lib/src/parse/opreturn.ts

Loading...