Page MenuHomePhabricator
Differential D18804

[Cashtab] IOS: play nicely with the notification bar
ClosedPublic
Actions

Authored by Fabien on Oct 20 2025, 08:34.

Details

Reviewers
bytesofman
Group Reviewers
Restricted Project
Commits
rABC49020588ef74: [Cashtab] IOS: play nicely with the notification bar
Summary

On devices with a notch the app collides with the notification area. This is fixed by offsetting the content using the safe area values provided by iOS WebKit.
This leaves the notification bar with the default device theme which is ugly, so we also override the theme for this app to match Cashtab design.

Before:

Screenshot 2025-10-17 at 17.02.43.png (2×1 px, 186 KB)

After:

Screenshot 2025-10-20 at 10.05.26.png (2×1 px, 207 KB)

Test Plan
./start-ios.sh

Check it doesn't break anything on Android:

./start-android.sh

Diff Detail

Repository
rABC Bitcoin ABC
Branch
cashtab-ios-safe-area
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 34813
Build 69088: Build Diffcashtab-tests
Build 69087: arc lint + arc unit

Event Timeline

Fabien created this revision.Oct 20 2025, 08:34
Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2025, 08:34
Fabien requested review of this revision.Oct 20 2025, 08:34
Harbormaster completed remote builds in B34813: Diff 56215.Oct 20 2025, 08:34
teamcity added a comment.Oct 20 2025, 08:34
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
Fabien edited the summary of this revision. (Show Details)Oct 20 2025, 08:35
teamcity added a comment.Oct 20 2025, 08:38
The build failed due to an unexpected infrastructure outage. The administrators have been notified to investigate. Sorry for the inconvenience.
bytesofman accepted this revision.Oct 20 2025, 11:39
bytesofman added a subscriber: bytesofman.

I'm not able to test but this is similar to how it's done on android

This revision is now accepted and ready to land.Oct 20 2025, 11:39
bytesofman added a comment.Oct 20 2025, 11:41

confirmed the android build still works and still has good safe areas

Closed by commit rABC49020588ef74: [Cashtab] IOS: play nicely with the notification bar (authored by Fabien). · Explain WhyOct 20 2025, 11:43
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rABC49020588ef74: [Cashtab] IOS: play nicely with the notification bar.

Revision Contents
Changeset List

PathSize
cashtab/
ios/
App/
App/
4 lines
4 lines
src/
components/
App/
13 lines

Diff 56215

View Options

cashtab/ios/App/App/AppDelegate.swift

Loading...
View Options

cashtab/ios/App/App/Info.plist

Loading...
View Options

cashtab/src/components/App/App.css

Loading...