coins, refactor: Assume state after SetClean in AddFlags to prevent dangling pointers
ClosedPublic
Actions

Authored by PiRK on Oct 20 2025, 14:09.

Details

Reviewers

Fabien

Group Reviewers

Restricted Project

Commits

rABC1b65cdc70328: coins, refactor: Assume state after SetClean in AddFlags to prevent dangling…

Summary

This is a partial backport of core#30906
https://github.com/bitcoin/bitcoin/pull/30906/commits/cd0498eabc910efa3ed7a6d32e687107248bb5be

Co-authored-by: Ryan Ofsky <ryan@ofsky.org>
Depends on D18807

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34830
Build 69122: Build Diff	build-diff · lint-circular-dependencies · build-without-wallet · build-debug · build-clang-tidy · build-clang
Build 69121: arc lint + arc unit

Event Timeline

PiRK created this revision.Oct 20 2025, 14:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptOct 20 2025, 14:09

PiRK requested review of this revision.Oct 20 2025, 14:09

teamcity edited the summary of this revision. (Show Details)Oct 20 2025, 14:09

PiRK added a child revision: D18809: coins, refactor: Remove direct GetFlags access.Oct 20 2025, 14:10

Harbormaster completed remote builds in B34820: Diff 56225.Oct 20 2025, 14:32

rebase

Harbormaster completed remote builds in B34830: Diff 56239.Oct 20 2025, 17:02

Fabien accepted this revision.Oct 21 2025, 07:13

This revision is now accepted and ready to land.Oct 21 2025, 07:13

Closed by commit rABC1b65cdc70328: coins, refactor: Assume state after SetClean in AddFlags to prevent dangling… (authored by Lőrinc <pap.lorinc@gmail.com>, committed by PiRK). · Explain WhyOct 21 2025, 12:42

This revision was automatically updated to reflect the committed changes.

PiRK added a commit: rABC1b65cdc70328: coins, refactor: Assume state after SetClean in AddFlags to prevent dangling….

Revision Contents
Changeset List

Path

Size

src/

coins.h

3 lines

Diff 56239

View Options

coins, refactor: Assume state after SetClean in AddFlags to prevent dangling pointersClosedPublicActions