Differential D1997

[tests] fix cross-platform sprintf issue in blockindex_tests
ClosedPublic
Actions

Authored by schancel on Nov 2 2018, 20:44.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGa38cb6434eae: [tests] fix cross-platform sprintf issue in blockindex_tests
rABCa38cb6434eae: [tests] fix cross-platform sprintf issue in blockindex_tests

Summary

As per title. Tinyformat does not print the same on every platform w/r/t pointers.
It does not seem follow the libc specification on Darwin. This patch fixes the issue
by using %p in both the test, and the ToString() method.

Additionally, use BOOST_CHECK_EQUAL so proper failure strings are printed in
the future.

Test Plan

make VERBOSE=1 check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

fix-blockindex-tests

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 3750
Build 5575: Bitcoin ABC Buildbot (legacy)
Build 5574: arc lint + arc unit

Event Timeline

schancel created this revision.Nov 2 2018, 20:44

Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 2 2018, 20:44

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel edited the summary of this revision. (Show Details)Nov 2 2018, 20:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B3750: Diff 5624.Nov 2 2018, 20:54

Fabien accepted this revision.Nov 2 2018, 20:56

This revision is now accepted and ready to land.Nov 2 2018, 20:56

Closed by commit rABCa38cb6434eae: [tests] fix cross-platform sprintf issue in blockindex_tests (authored by schancel). · Explain WhyNov 2 2018, 20:56

This revision was automatically updated to reflect the committed changes.

Revision Contents
Changeset List

Path

Size

src/

test/

blockindex_tests.cpp

17 lines

Diff 5624

View Options

src/test/blockindex_tests.cpp

[tests] fix cross-platform sprintf issue in blockindex_testsClosedPublicActions