Differential D18881

log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo, LogWarning, LogError
ClosedPublic
Actions

Authored by Fabien on Wed, Nov 5, 16:21.

Details

Reviewers

PiRK

Group Reviewers

Restricted Project

Commits

rABCadb30b7ab03d: log: Mitigate disk filling attacks by rate limiting LogPrintf, LogInfo…

Summary

Each source code location is given an hourly logging quota of 1MiB of logging per hour. Logging is only dropped from source locations that exceed the quota.

 - Only logging to disk is rate limited. Logging to console is not rate limited.
 - Printing with the category argument is not rate limited.
 - UpdateTip: new best=[…] is logged without rate limiting. High log volume is expected for that source location during IBD.
 - When logging is restarted a tally of how many bytes were dropped is printed.
 - All logs will be prefixed with [*] if there is at least one source location that is currently being suppressed.

Backport of core#32604.

Depends on D18875.

Test Plan

ninja all check-all

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR32604

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 34969
Build 69400: Build Diff	build-without-wallet · lint-circular-dependencies · ecash-lib-integration-tests · chronik-client-integration-tests · ecash-agora-integration-tests · build-diff · build-chronik-plugins · build-debug · build-clang-tidy · build-clang · build-chronik
Build 69399: arc lint + arc unit

Event Timeline

Fabien created this revision.Wed, Nov 5, 16:21

Herald added a reviewer: Restricted Project. · View Herald TranscriptWed, Nov 5, 16:21

Fabien requested review of this revision.Wed, Nov 5, 16:21

teamcity edited the summary of this revision. (Show Details)Wed, Nov 5, 16:21

Harbormaster completed remote builds in B34969: Diff 56440.Wed, Nov 5, 16:29

Build Bitcoin ABC Diffs / Diff Testing (chronik-client-integration-tests) failed.

Tail of the build log:

[407/595] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[408/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[409/595] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[410/595] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[411/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[412/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[413/595] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[414/595] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[415/595] Linking CXX executable src/bitcoin-cli
[416/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[417/595] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[418/595] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[419/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[420/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[421/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[422/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[423/595] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[424/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[425/595] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[426/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[427/595] Linking CXX executable src/bitcoin-tx
[428/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[429/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[430/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[431/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[432/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[433/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[434/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[435/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[436/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[437/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[438/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[439/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[440/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[441/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[442/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[443/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[444/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[445/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[446/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[447/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[448/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[449/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[450/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[451/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[452/595] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[453/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[454/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[455/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[456/595] Linking CXX executable src/iguana/iguana
[457/595] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[458/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[459/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[460/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[461/595] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[462/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[463/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[464/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build chronik-client-integration-tests failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (ecash-agora-integration-tests) failed.

Tail of the build log:

[407/595] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[408/595] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[409/595] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[410/595] Linking C executable src/secp256k1/internal-bench
[411/595] Linking C executable src/secp256k1/ecmult-bench
[412/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[413/595] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[414/595] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[415/595] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[416/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[417/595] Linking CXX executable src/bitcoin-cli
[418/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[419/595] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[420/595] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[421/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[422/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[423/595] Linking CXX executable src/bitcoin-tx
[424/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[425/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[426/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[427/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[428/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[429/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[430/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[431/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[432/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[433/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[434/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[435/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[436/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[437/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[438/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[439/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[440/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[441/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[442/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[443/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[444/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[445/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[446/595] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[447/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[448/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[449/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[450/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[451/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[452/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[453/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[454/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[455/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[456/595] Linking CXX executable src/iguana/iguana
[457/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[458/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[459/595] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[460/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[461/595] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[462/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[463/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[464/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build ecash-agora-integration-tests failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-clang-tidy) failed.

Tail of the build log:

[407/595] Linking C executable src/secp256k1/ecmult-bench
[408/595] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[409/595] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[410/595] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[411/595] Linking CXX executable src/bitcoin-cli
[412/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[413/595] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[414/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[415/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[416/595] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[417/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[418/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[419/595] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[420/595] Linking CXX executable src/bitcoin-tx
[421/595] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[422/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[423/595] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[424/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[425/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[426/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[427/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[428/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[429/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[430/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[431/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[432/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[433/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[434/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[435/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[436/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[437/595] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[438/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[439/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[440/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[441/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[442/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[443/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[444/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[445/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[446/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[447/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[448/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[449/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[450/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[451/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[452/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[453/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[454/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[455/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[456/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[457/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[458/595] Linking CXX executable src/iguana/iguana
[459/595] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[460/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[461/595] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[462/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[463/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[464/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-chronik) failed.

Tail of the build log:

[407/596] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[408/596] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[409/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[410/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[411/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[412/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[413/596] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[414/596] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[415/596] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[416/596] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[417/596] Linking CXX executable src/bitcoin-cli
[418/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[419/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[420/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[421/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[422/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[423/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[424/596] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[425/596] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[426/596] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[427/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[428/596] Linking CXX executable src/bitcoin-tx
[429/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[430/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[431/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[432/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[433/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[434/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[435/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[436/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[437/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[438/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[439/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[440/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[441/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[442/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[443/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[444/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[445/596] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[446/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[447/596] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[448/596] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[449/596] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[450/596] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[451/596] Linking CXX executable src/iguana/iguana
[452/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[453/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[454/596] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[455/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[456/596] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[457/596] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[458/596] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[459/596] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[460/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[461/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[462/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[463/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[464/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (build-chronik-plugins) failed.

Tail of the build log:

[407/596] Linking C executable src/secp256k1/internal-bench
[408/596] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[409/596] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[410/596] Linking C executable src/secp256k1/ecmult-bench
[411/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[412/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[413/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[414/596] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[415/596] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[416/596] Linking CXX executable src/bitcoin-cli
[417/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[418/596] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[419/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[420/596] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[421/596] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[422/596] Linking CXX executable src/bitcoin-tx
[423/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[424/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[425/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[426/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[427/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[428/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[429/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[430/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[431/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[432/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[433/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[434/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[435/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[436/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[437/596] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[438/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[439/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[440/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[441/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[442/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[443/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[444/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[445/596] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[446/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[447/596] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[448/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[449/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[450/596] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[451/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[452/596] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[453/596] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[454/596] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[455/596] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[456/596] Linking CXX executable src/iguana/iguana
[457/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[458/596] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[459/596] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[460/596] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[461/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[462/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[463/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[464/596] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-chronik-plugins failed with exit code 1

Build Bitcoin ABC Diffs / Diff Testing (ecash-lib-integration-tests) failed.

Tail of the build log:

[407/595] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[408/595] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[409/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[410/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[411/595] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[412/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[413/595] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[414/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[415/595] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[416/595] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[417/595] Linking CXX executable src/bitcoin-cli
[418/595] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[419/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[420/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[421/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[422/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[423/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[424/595] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[425/595] Linking CXX executable src/bitcoin-tx
[426/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[427/595] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[428/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[429/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[430/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[431/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[432/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[433/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[434/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[435/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[436/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[437/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[438/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[439/595] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[440/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[441/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[442/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[443/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[444/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[445/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[446/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[447/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[448/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[449/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[450/595] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[451/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[452/595] Linking CXX executable src/iguana/iguana
[453/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[454/595] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[455/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[456/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[457/595] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[458/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[459/595] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[460/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[461/595] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[462/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[463/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[464/595] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build ecash-lib-integration-tests failed with exit code 1

Fabien planned changes to this revision.Wed, Nov 5, 16:49

Rebase to get c++20 for chronik

Harbormaster completed remote builds in B34970: Diff 56445.Wed, Nov 5, 17:34

PiRK accepted this revision.Wed, Nov 5, 19:07

PiRK added a subscriber: PiRK.

PiRK added inline comments.