Page MenuHomePhabricator
Differential D18950

[Cashtab] Automatically update android app version from package dot json
ClosedPublic
Actions

Authored by bytesofman on Mon, Nov 17, 19:21.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABCf515221905b0: [Cashtab] Automatically update android app version from package dot json
Summary

We want to keep the android app in sync with the webapp and the extension. Pull the version number from package.json for release builds.

Test Plan

./build-android-release.sh, version matches

Diff Detail

Repository
rABC Bitcoin ABC
Branch
android-app-version
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 35088
Build 69635: Build Diffcashtab-tests
Build 69634: arc lint + arc unit

Event Timeline

bytesofman created this revision.Mon, Nov 17, 19:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMon, Nov 17, 19:21
Harbormaster completed remote builds in B35088: Diff 56638.Mon, Nov 17, 19:29
bytesofman published this revision for review.Mon, Nov 17, 19:35
Fabien accepted this revision.Tue, Nov 18, 10:56
Fabien added a subscriber: Fabien.
Fabien added inline comments.
cashtab/build-android-release.sh
35

Macro likestamp:

This revision is now accepted and ready to land.Tue, Nov 18, 10:56
Closed by commit rABCf515221905b0: [Cashtab] Automatically update android app version from package dot json (authored by bytesofman). · Explain WhyTue, Nov 18, 13:16
This revision was automatically updated to reflect the committed changes.
bytesofman added a commit: rABCf515221905b0: [Cashtab] Automatically update android app version from package dot json.

Revision Contents
Changeset List

PathSize
cashtab/
android/
app/
21 lines
8 lines

Diff 56638

View Options

cashtab/android/app/build.gradle

Loading...
View Options

cashtab/build-android-release.sh

Loading...