Page MenuHomePhabricator

Allow FastRandomContext::randbytes for all byte types
AcceptedPublic

Authored by PiRK on Tue, Dec 2, 15:53.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Summary
Test Plan

ninja all check-all

Event Timeline

PiRK requested review of this revision.Tue, Dec 2, 15:53

Tail of the build log:

-- Install component: "secp256k1"
-- Installing: /results/artifacts/lib/libsecp256k1.a
-- Installing: /results/artifacts/include/secp256k1.h
-- Installing: /results/artifacts/include/secp256k1_preallocated.h
-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[396/589] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[397/589] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[398/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[399/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[400/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[401/589] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[402/589] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[403/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[404/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[405/589] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[406/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[407/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[408/589] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[409/589] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[410/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[411/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[412/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[413/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[414/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[415/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[416/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[417/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[418/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[419/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[420/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[421/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[422/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[423/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[424/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[425/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[426/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[427/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[428/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[429/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[430/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[431/589] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[432/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[433/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[434/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[435/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[436/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[437/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[438/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[439/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[440/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[441/589] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[442/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[443/589] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[444/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[445/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[446/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
[447/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang failed with exit code 1

Tail of the build log:

[236/599] Building CXX object src/CMakeFiles/common.dir/common/args.cpp.o
[237/599] Building CXX object src/CMakeFiles/common.dir/merkleblock.cpp.o
[238/599] Building CXX object src/CMakeFiles/common.dir/key.cpp.o
[239/599] Building CXX object src/CMakeFiles/common.dir/kernel/chainparams.cpp.o
[240/599] Building CXX object src/CMakeFiles/common.dir/net_permissions.cpp.o
[241/599] Building CXX object src/CMakeFiles/common.dir/primitives/block.cpp.o
[242/599] Building CXX object src/CMakeFiles/common.dir/key_io.cpp.o
[243/599] Building CXX object src/CMakeFiles/common.dir/core_write.cpp.o
[244/599] Building CXX object src/CMakeFiles/common.dir/netaddress.cpp.o
[245/599] Building CXX object src/CMakeFiles/common.dir/scheduler.cpp.o
[246/599] Building CXX object src/CMakeFiles/common.dir/policy/policy.cpp.o
[247/599] Building CXX object src/CMakeFiles/script.dir/script/bitfield.cpp.o
[248/599] Building CXX object src/CMakeFiles/common.dir/netbase.cpp.o
[249/599] Building CXX object src/CMakeFiles/script.dir/script/intmath.cpp.o
[250/599] Building CXX object src/CMakeFiles/common.dir/networks/abc/chainparamsconstants.cpp.o
[251/599] Building CXX object src/CMakeFiles/common.dir/outputtype.cpp.o
[252/599] Building CXX object src/CMakeFiles/script.dir/script/script_error.cpp.o
[253/599] Building CXX object src/CMakeFiles/common.dir/protocol.cpp.o
[254/599] Building CXX object src/CMakeFiles/common.dir/warnings.cpp.o
[255/599] Building CXX object src/CMakeFiles/common.dir/core_read.cpp.o
[256/599] Building CXX object src/CMakeFiles/common.dir/rpc/request.cpp.o
[257/599] Building CXX object src/CMakeFiles/script.dir/script/script.cpp.o
[258/599] Building CXX object src/CMakeFiles/common.dir/networks/abc/checkpoints.cpp.o
[259/599] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/arith_uint256.cpp.o
[260/599] Building CXX object src/CMakeFiles/script.dir/script/sigencoding.cpp.o
[261/599] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/uint256.cpp.o
[262/599] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/hash.cpp.o
[263/599] Building CXX object src/CMakeFiles/common.dir/psbt.cpp.o
[264/599] Building CXX object src/CMakeFiles/common.dir/rpc/rawtransaction_util.cpp.o
[265/599] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/util/strencodings.cpp.o
[266/599] Building CXX object src/CMakeFiles/script.dir/script/interpreter.cpp.o
[267/599] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[268/599] Linking C static library src/secp256k1/libsecp256k1.a
[269/599] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[270/599] Building CXX object src/CMakeFiles/script.dir/script/standard.cpp.o
[271/599] Linking C executable src/secp256k1/recover-bench
[272/599] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[273/599] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[274/599] Linking C executable src/secp256k1/verify-bench
[275/599] Linking C executable src/secp256k1/sign-bench
[276/599] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[277/599] Linking C executable src/secp256k1/internal-bench
[278/599] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[279/599] Linking C executable src/secp256k1/ecmult-bench
[280/599] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/primitives/transaction.cpp.o
[281/599] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/pubkey.cpp.o
[282/599] Building CXX object src/CMakeFiles/script.dir/script/sign.cpp.o
[283/599] Building CXX object src/CMakeFiles/script.dir/script/signingprovider.cpp.o
[284/599] Building CXX object src/CMakeFiles/common.dir/rpc/util.cpp.o
[285/599] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/amount.cpp.o
[286/599] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[287/599] Building CXX object src/CMakeFiles/bitcoinconsensus.dir/consensus/tx_check.cpp.o
[288/599] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[289/599] Building CXX object src/CMakeFiles/script.dir/script/descriptor.cpp.o
[290/599] Building CXX object src/CMakeFiles/bitcoinconsensus-shared.dir/script/bitcoinconsensus.cpp.o
[291/599] Building CXX object src/CMakeFiles/bitcoin-cli.dir/bitcoin-cli.cpp.o
[292/599] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[293/599] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-clang-tidy failed with exit code 1

Tail of the build log:

-- Installing: /results/artifacts/include/secp256k1_recovery.h
-- Installing: /results/artifacts/include/secp256k1_schnorr.h
[392/589] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[393/589] Linking C executable src/secp256k1/internal-bench
[394/589] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[395/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[396/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[397/589] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[398/589] Linking C executable src/secp256k1/ecmult-bench
[399/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[400/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[401/589] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[402/589] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[403/589] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[404/589] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[405/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[406/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[407/589] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[408/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[409/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[410/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[411/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[412/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[413/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[414/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[415/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[416/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[417/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[418/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[419/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[420/589] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[421/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[422/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[423/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[424/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[425/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[426/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[427/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[428/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[429/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[430/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[431/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[432/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[433/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[434/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[435/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[436/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[437/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[438/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[439/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[440/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[441/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[442/589] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[443/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[444/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[445/589] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[446/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[447/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-debug failed with exit code 1

Tail of the build log:

[390/589] Building CXX object src/CMakeFiles/server.dir/txpool.cpp.o
[391/589] Building CXX object src/CMakeFiles/server.dir/rpc/avalanche.cpp.o
[392/589] Building CXX object src/CMakeFiles/server.dir/validationinterface.cpp.o
[393/589] Building CXX object src/CMakeFiles/server.dir/net_processing.cpp.o
[394/589] Building CXX object src/CMakeFiles/server.dir/torcontrol.cpp.o
[395/589] Building CXX object src/CMakeFiles/server.dir/rpc/rawtransaction.cpp.o
[396/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[397/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[398/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[399/589] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[400/589] Building CXX object src/CMakeFiles/server.dir/txmempool.cpp.o
[401/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[402/589] Building CXX object src/CMakeFiles/bitcoin-wallet.dir/bitcoin-wallet.cpp.o
[403/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[404/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[405/589] Building CXX object src/CMakeFiles/bitcoin-tx.dir/bitcoin-tx.cpp.o
[406/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/context.cpp.o
[407/589] Building CXX object src/CMakeFiles/server.dir/rpc/blockchain.cpp.o
[408/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/db.cpp.o
[409/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[410/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[411/589] Building CXX object src/CMakeFiles/server.dir/wallet/init.cpp.o
[412/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/coincontrol.cpp.o
[413/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/crypter.cpp.o
[414/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[415/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[416/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[417/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/coinselection.cpp.o
[418/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[419/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/bdb.cpp.o
[420/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/fees.cpp.o
[421/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/load.cpp.o
[422/589] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[423/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/receive.cpp.o
[424/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/util.cpp.o
[425/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/signmessage.cpp.o
[426/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/transaction.cpp.o
[427/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/sqlite.cpp.o
[428/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/encrypt.cpp.o
[429/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[430/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/salvage.cpp.o
[431/589] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[432/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/interfaces.cpp.o
[433/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletutil.cpp.o
[434/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[435/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[436/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/spend.cpp.o
[437/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[438/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[439/589] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[440/589] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[441/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/scriptpubkeyman.cpp.o
[442/589] Building CXX object src/wallet/CMakeFiles/wallet-tool.dir/wallettool.cpp.o
[443/589] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[444/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpc/backup.cpp.o
[445/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/walletdb.cpp.o
[446/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/rpcwallet.cpp.o
[447/589] Building CXX object src/wallet/CMakeFiles/wallet.dir/wallet.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-diff failed with exit code 1

Tail of the build log:

[502/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/netbase.cpp.o
[503/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/node/eviction.cpp.o
[504/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/net.cpp.o
[505/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/rtt.cpp.o
[506/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/node/ui_interface.cpp.o
[507/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/minerfund.cpp.o
[508/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/protocol.cpp.o
[509/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/error.cpp.o
[510/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/readwritefile.cpp.o
[511/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/timedata.cpp.o
[512/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/asmap.cpp.o
[513/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/util/sock.cpp.o
[514/669] Building C object src/secp256k1/CMakeFiles/secp256k1.dir/src/secp256k1.c.o
[515/669] Linking C static library src/secp256k1/libsecp256k1.a
[516/669] Building C object src/secp256k1/CMakeFiles/recover-bench.dir/src/bench_recover.c.o
[517/669] Linking C executable src/secp256k1/recover-bench
[518/669] Building C object src/secp256k1/CMakeFiles/verify-bench.dir/src/bench_verify.c.o
[519/669] Linking C executable src/secp256k1/verify-bench
[520/669] Building C object src/secp256k1/CMakeFiles/sign-bench.dir/src/bench_sign.c.o
[521/669] Linking C executable src/secp256k1/sign-bench
[522/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/proofpool.cpp.o
[523/669] Building CXX object src/CMakeFiles/bitcoind.dir/bitcoind.cpp.o
[524/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/proof.cpp.o
[525/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/node/blockstorage.cpp.o
[526/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/stakecontendercache.cpp.o
[527/669] Building C object src/secp256k1/CMakeFiles/internal-bench.dir/src/bench_internal.c.o
[528/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/txmempool.cpp.o
[529/669] Linking C executable src/secp256k1/internal-bench
[530/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/stakingrewards.cpp.o
[531/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/policy/block/preconsensus.cpp.o
[532/669] Building C object src/secp256k1/CMakeFiles/ecmult-bench.dir/src/bench_ecmult.c.o
[533/669] Linking C executable src/secp256k1/ecmult-bench
[534/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/str.cpp.o
[535/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockindex.cpp.o
[536/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/coins.cpp.o
[537/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/logging.cpp.o
[538/669] Building CXX object src/CMakeFiles/bitcoin-chainstate.dir/bitcoin-chainstate.cpp.o
[539/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/random.cpp.o
[540/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/blockfilter.cpp.o
[541/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/transaction_utils.cpp.o
[542/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/net.cpp.o
[543/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/peermanager.cpp.o
[544/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/wallet.cpp.o
[545/669] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/dns.cpp.o
[546/669] Building CXX object src/CMakeFiles/server.dir/validation.cpp.o
[547/669] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/db.cpp.o
[548/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/validation.cpp.o
[549/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/avalanche/processor.cpp.o
[550/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/mining.cpp.o
[551/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/txmempool.cpp.o
[552/669] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_formatter.cpp.o
[553/669] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana_interpreter.cpp.o
[554/669] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/options.cpp.o
[555/669] Building CXX object src/iguana/CMakeFiles/iguana.dir/iguana.cpp.o
[556/669] Building CXX object src/seeder/CMakeFiles/seeder-base.dir/bitcoin.cpp.o
[557/669] Building CXX object src/seeder/CMakeFiles/bitcoin-seeder.dir/main.cpp.o
[558/669] Building CXX object src/test/CMakeFiles/testutil.dir/util/setup_common.cpp.o
[559/669] Building CXX object src/CMakeFiles/bitcoinkernel.dir/validation.cpp.o
ninja: build stopped: cannot make progress due to previous errors.
Build build-without-wallet failed with exit code 1
PiRK planned changes to this revision.Tue, Dec 2, 19:56

will investigate tomorrow (maybe a clang specific issue)

Not clang specific. It seems this has a hidden dependency on the D19015-19022 stack. I initially tested it there before cherry-picking the commits to their own branch

PiRK edited the summary of this revision. (Show Details)

add missing UCharCast overload

This revision is now accepted and ready to land.Wed, Dec 3, 10:09