Page MenuHomePhabricator
Differential D2090

Fix sources of flackiness in p2p-fullblocktest.py
ClosedPublic
Actions

Authored by deadalnix on Nov 18 2018, 23:25.

Details

Reviewers
schancel
Group Reviewers
Restricted Project
Commits
rSTAGING65b595d16cc5: Fix sources of flackiness in p2p-fullblocktest.py
rABC65b595d16cc5: Fix sources of flackiness in p2p-fullblocktest.py
Summary

Some of the test end up being dependent on transaction order (base on ids) and therefore flacky.

Test Plan
./test/functional/test_runner.py p2p-fullblocktest.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
p2p-fullblocktest-2
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 3967
Build 6006: Bitcoin ABC Buildbot (legacy)
Build 6005: arc lint + arc unit

Event Timeline

deadalnix created this revision.Nov 18 2018, 23:25
Herald added a reviewer: Restricted Project. · View Herald TranscriptNov 18 2018, 23:25
teamcity added a subscriber: teamcity.Nov 18 2018, 23:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

schancel accepted this revision.Nov 18 2018, 23:27
schancel added a subscriber: schancel.
schancel added inline comments.
test/functional/p2p-fullblocktest.py
808

This is why I used the merkleRootDirectly.

This revision is now accepted and ready to land.Nov 18 2018, 23:27
Closed by commit rABC65b595d16cc5: Fix sources of flackiness in p2p-fullblocktest.py (authored by deadalnix). · Explain WhyNov 18 2018, 23:28
This revision was automatically updated to reflect the committed changes.
teamcity added a comment.Nov 18 2018, 23:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing failed.

Harbormaster failed remote builds in B3967: Diff 5900!Nov 18 2018, 23:33

Revision Contents
Changeset List

PathSize
test/
functional/
19 lines

Diff 5900

View Options

test/functional/p2p-fullblocktest.py

Loading...