This would avoid rebuilding the whole source tree at each version
change.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING181dea75e1ea: Separate version info into bitcoin-version.h from bitcoin-config.h
rABC181dea75e1ea: Separate version info into bitcoin-version.h from bitcoin-config.h
./autogen.sh mkdir build && cd build ../configure make check rm -rf * CONFIG_SITE=../depends/i686-w64-mingw32/share/config.site ../configure \ --with-seeder=false make rm -rf * CONFIG_SITE=../depends/x86_64-w64-mingw32/share/config.site \ ../configure --with-seeder=false make cd .. && mkdir buildcmake && cd buildcmake cmake -GNinja .. ninja check rm -rf * cmake -GNinja .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win32.cmake \ -DBUILD_BITCOIN_SEEDER=OFF ninja rm -rf * cmake -GNinja .. -DCMAKE_TOOLCHAIN_FILE=../cmake/platforms/Win64.cmake \ -DBUILD_BITCOIN_SEEDER=OFF ninja
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- version_split_build
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5878 Build 9816: Bitcoin ABC Buildbot (legacy) Build 9815: arc lint + arc unit
Event Timeline
Comment Actions
config contains allt he confgure generated files, so config/version.h would make much more sense.
| src/CMakeLists.txt | ||
|---|---|---|
| 22 ↗ | (On Diff #8696) | Unless this is needed anywhere in here, I think it can stay in config. |
| src/bitcoin-cli-res.rc | ||
| 2 ↗ | (On Diff #8696) | Considering this patterns repeats itself a bazillion times, it may make sense to either include this from version.h or to also move the copyright infos in version.h . |
| src/bitcoin-version.h.in | ||
| 12 ↗ | (On Diff #8696) | There should be one template for cmake and one for configure. These define should be removed from the other configure template. |
Comment Actions
Will move to src/config/ and include copyright defines in it.
| src/bitcoin-version.h.in | ||
|---|---|---|
| 12 ↗ | (On Diff #8696) | The defines are removed from the CMake template. The autotools one is generated by autoheader. |
Comment Actions
Move to src/config/bitcoin-version.h, separate templates, keep resource files unchanged.