The error message when the miniupnpc.h is not found is fubared due the
CMAKE_REQUIRED_INCLUDES not taking into account the NOTFOUND case. This
diff fixes the issue and restore the expected error.
Details
Details
- Reviewers
deadalnix - Group Reviewers
Restricted Project - Commits
- rSTAGING1d6c9eac7c10: [CMAKE] Fix Miniupnpc error message
rABC1d6c9eac7c10: [CMAKE] Fix Miniupnpc error message
Uninstall miniupnpc, then
mkdir buildcmake && cd buildcmake cmake -GNinja ..
Should output a CMake error:
Could NOT find MiniUPnPc (missing: MINIUPNPC_INCLUDE_DIR MINIUPNPC_LIBRARY)
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- cmake_fix_miniupnpc_error_message
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 6034 Build 10127: Bitcoin ABC Buildbot (legacy) Build 10126: arc lint + arc unit